linux-kernel - Re: [PATCH v2] evm: Fix memory leak in init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <31aed9f12482d1156c224c2cc5ac8afd81e8cb14.camel@linux.ibm.com>
Date:   Mon, 11 Jan 2021 08:46:40 -0500
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     Markus Elfring <Markus.Elfring@....de>,
        Dinghao Liu <dinghao.liu@....edu.cn>,
        Eric Biggers <ebiggers@...nel.org>,
        linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Dmitry Kasatkin <dmitry.kasatkin@...ia.com>,
        James Morris <jmorris@...ei.org>, Kangjie Lu <kjlu@....edu>,
        "Serge E. Hallyn" <serge@...lyn.com>
Subject: Re: [PATCH v2] evm: Fix memory leak in init_desc

Hi Dinghao,

On Sun, 2021-01-10 at 11:50 +0100, Markus Elfring wrote:
> > When kmalloc() fails, tmp_tfm allocated by
> > crypto_alloc_shash() has not been freed, which
> > leads to memleak.

In the future, please conform to Documentation/process/submitting-
patches.rst: 

  - The body of the explanation, line wrapped at 75 columns, which will
    be copied to the permanent changelog to describe this patch.

> 
> Do any Linux developers care for the following aspects?
> 
> * Imperative wordings for change descriptions
>   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=2ff90100ace886895e4fbb2850b8d5e49d931ed6#n89
> 
> * Usage of the term “memory leak” (instead of an abbreviation)

In general I agree, but this is a really small, obvious bug fix. 
Assuming Dinghao is fine with my updating the patch description, I'll
fix it.

Mimi