lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 12 Jan 2021 15:20:36 +0100 From: Daniel Vetter <daniel@...ll.ch> To: "ZhiJie.Zhang" <zhangzhijie@...ngson.cn> Cc: maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de, airlied@...ux.ie, daniel@...ll.ch, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] drm: Improve the output_poll_changed description On Tue, Jan 12, 2021 at 06:46:44PM +0800, ZhiJie.Zhang wrote: > From: zhangzhijie <zhangzhijie@...ngson.cn> > > codeview the implementation of few Drivers. I'm not really understanding what you're trying to say here. > this callback was used by drm_kms_helper_hotplug_event() > > Signed-off-by: zhangzhijie <zhangzhijie@...ngson.cn> > --- > include/drm/drm_mode_config.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h > index ab424ddd7665..e01c4d0f07d1 100644 > --- a/include/drm/drm_mode_config.h > +++ b/include/drm/drm_mode_config.h > @@ -104,7 +104,7 @@ struct drm_mode_config_funcs { > * changes. > * > * Drivers implementing fbdev emulation with the helpers can call > - * drm_fb_helper_hotplug_changed from this hook to inform the fbdev > + * drm_kms_helper_hotplug_event() from this hook to inform the fbdev > * helper of output changes. I think since we touch this, maybe better to revamp it complete. The best way to handle all this is by registering a struct drm_client, since that provides the &drm_client_funcs.hotplug callback. Also for fbdev support drivers shouldn't even use that, but instead use the drm_fbdev_generic_setup() function, which takes care of everything. I think we can also remove the FIXME below, since with the drm_client infrastructure and the generic fbdev emulation we've resolved this all very neatly now. Can you please respin with my suggestions taking into account somehow? Thanks, Daniel > * > * FIXME: > -- > 2.29.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Powered by blists - more mailing lists