linux-kernel - Re: [PATCH v0 net-next 1/1] Allow user to set metric on default route learned via Router Advertisement.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Jan 2021 15:16:50 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Praveen Chaudhary <praveen5582@...il.com>
Cc:     davem@...emloft.net, corbet@....net, kuznet@....inr.ac.ru,
        yoshfuji@...ux-ipv6.org, netdev@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Zhenggen Xu <zxu@...kedin.com>
Subject: Re: [PATCH v0 net-next 1/1] Allow user to set metric on default
 route learned via Router Advertisement.

On Mon, 11 Jan 2021 13:58:29 -0800 Praveen Chaudhary wrote:
> For IPv4, default route is learned via DHCPv4 and user is allowed to change
> metric using config etc/network/interfaces. But for IPv6, default route can
> be learned via RA, for which, currently a fixed metric value 1024 is used.
> 
> Ideally, user should be able to configure metric on default route for IPv6
> similar to IPv4. This fix adds sysctl for the same.
> 
> Signed-off-by: Praveen Chaudhary<pchaudhary@...kedin.com>
> Signed-off-by: Zhenggen Xu<zxu@...kedin.com>

Please put a space between the name and '<'.

I haven't looked at the code yet, but I can tell you this patch
triggers a few checkpatch --strict warnings, and breaks allmodconfig
build.