lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 Jan 2021 18:17:50 -0500 From: Thara Gopinath <thara.gopinath@...aro.org> To: Daniel Lezcano <daniel.lezcano@...aro.org>, rui.zhang@...el.com Cc: mjg59@...on.org.uk, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, amitk@...nel.org Subject: Re: [PATCH 3/6] thermal/core: Remove pointless test with the THERMAL_TRIPS_NONE macro On 12/14/20 6:38 PM, Daniel Lezcano wrote: > The THERMAL_TRIPS_NONE is equal to -1, it is pointless to do a > conversion in this function. It is pointless because you have removed force_passive and will be removing THERMAL_TRIPS_NONE in the following patches. Maybe that should be mentioned in the commit message. Otherwise, Reviewed-by: Thara Gopinath <thara.gopinath@...aro.org> > > Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org> > --- > drivers/thermal/thermal_sysfs.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/thermal/thermal_sysfs.c b/drivers/thermal/thermal_sysfs.c > index 4e7f9e880d76..345917a58f2f 100644 > --- a/drivers/thermal/thermal_sysfs.c > +++ b/drivers/thermal/thermal_sysfs.c > @@ -875,10 +875,7 @@ trip_point_show(struct device *dev, struct device_attribute *attr, char *buf) > instance = > container_of(attr, struct thermal_instance, attr); > > - if (instance->trip == THERMAL_TRIPS_NONE) > - return sprintf(buf, "-1\n"); > - else > - return sprintf(buf, "%d\n", instance->trip); > + return sprintf(buf, "%d\n", instance->trip); > } > > ssize_t > -- Warm Regards Thara
Powered by blists - more mailing lists