linux-kernel - Re: [PATCH v2] nvmet-fc: associations list protected by rcu, instead of spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d7f5b89-f8a2-f80f-cf8e-d7dc0470acca@broadcom.com>
Date:   Mon, 11 Jan 2021 15:46:20 -0800
From:   James Smart <james.smart@...adcom.com>
To:     leonid.ravich@...l.com
Cc:     lravich@...il.com, Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>,
        Chaitanya Kulkarni <chaitanya.kulkarni@....com>,
        linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] nvmet-fc: associations list protected by rcu, instead
 of spinlock_irq where possible.



On 1/3/2021 10:12 AM, leonid.ravich@...l.com wrote:
> From: Leonid Ravich <Leonid.Ravich@....com>
>
> searching assoc_list protected by rcu_read_lock if list not changed inline.
> and according to the rcu list rules.
>
> queue array embedded into nvmet_fc_tgt_assoc protected by rcu_read_lock
> according to rcu dereference/assign rules.
>
> queue and assoc object freed after grace period by call_rcu.
>
> tgtport lock taken for changing assoc_list.
>
> Reviewed-by: Eldad Zinger <Eldad.Zinger@...l.com>
> Reviewed-by: Elad Grupi <Elad.Grupi@...l.com>
> Signed-off-by: Leonid Ravich <Leonid.Ravich@....com>
> ---
> 1) fixed sytle issus
> 2) queues array protects by rcu as well
>
>   drivers/nvme/target/fc.c | 81 +++++++++++++++++++++++-------------------------
>   1 file changed, 38 insertions(+), 43 deletions(-)
>
>

Reviewed-by: James Smart <james.smart@...adcom.com>

-- james


Download attachment "smime.p7s" of type "application/pkcs7-signature" (4163 bytes)