linux-kernel - Re: [PATCH] scsi: mpt3sas: Simplify _base_display_OEMs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <60398acb9f26e60e3c1d6ab9c2d8bab4a89f2a91.camel@perches.com>
Date:   Tue, 12 Jan 2021 09:46:10 -0800
From:   Joe Perches <joe@...ches.com>
To:     Johannes Thumshirn <Johannes.Thumshirn@....com>,
        Sathya Prakash <sathya.prakash@...adcom.com>,
        Sreekanth Reddy <sreekanth.reddy@...adcom.com>,
        Suganath Prabu Subramani 
        <suganath-prabu.subramani@...adcom.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     "MPT-FusionLinux.pdl@...adcom.com" <MPT-FusionLinux.pdl@...adcom.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: mpt3sas: Simplify _base_display_OEMs_branding

On Tue, 2021-01-12 at 17:40 +0000, Johannes Thumshirn wrote:
> On 12/01/2021 18:38, Joe Perches wrote:
> >  static void
> >  _base_display_OEMs_branding(struct MPT3SAS_ADAPTER *ioc)
> >  {
> > +	const char *b = NULL;	/* brand */
> > +	const char *v = NULL;	/* vendor */
> 
> Any reason you didn't spell out brand and vendor as the variable names?

80 column lines.