lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 12 Jan 2021 10:10:25 -0800
From:   Ben Gardon <>
Cc:     Paolo Bonzini <>, Peter Xu <>,
        Sean Christopherson <>,
        Peter Shier <>,
        Peter Feiner <>,
        Junaid Shahid <>,
        Jim Mattson <>,
        Yulei Zhang <>,
        Wanpeng Li <>,
        Vitaly Kuznetsov <>,
        Xiao Guangrong <>,
        Ben Gardon <>
Subject: [PATCH 08/24] kvm: x86/mmu: Add lockdep when setting a TDP MMU SPTE

Add lockdep to __tdp_mmu_set_spte to ensure that SPTEs are only modified
under the MMU lock. This lockdep will be updated in future commits to
reflect and validate changes to the TDP MMU's synchronization strategy.

No functional change intended.

Reviewed-by: Peter Feiner <>

Signed-off-by: Ben Gardon <>
 arch/x86/kvm/mmu/tdp_mmu.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/x86/kvm/mmu/tdp_mmu.c b/arch/x86/kvm/mmu/tdp_mmu.c
index b033da8243fc..411938e97a00 100644
--- a/arch/x86/kvm/mmu/tdp_mmu.c
+++ b/arch/x86/kvm/mmu/tdp_mmu.c
@@ -381,6 +381,8 @@ static inline void __tdp_mmu_set_spte(struct kvm *kvm, struct tdp_iter *iter,
 	struct kvm_mmu_page *root = sptep_to_sp(root_pt);
 	int as_id = kvm_mmu_page_as_id(root);
+	lockdep_assert_held(&kvm->mmu_lock);
 	WRITE_ONCE(*iter->sptep, new_spte);
 	__handle_changed_spte(kvm, as_id, iter->gfn, iter->old_spte, new_spte,

Powered by blists - more mailing lists