lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 12 Jan 2021 19:37:55 +0100 From: Hans de Goede <hdegoede@...hat.com> To: Perry Yuan <perry979106@...il.com>, Barnabás Pőcze <pobrn@...tonmail.com>, Perry Yuan <Perry.Yuan@...l.com> Cc: "mgross@...ux.intel.com" <mgross@...ux.intel.com>, "platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Limonciello Mario <Mario.Limonciello@...l.com> Subject: Re: [PATCH v2 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy Hi, I know there already is a v3 out and I will try to get around to reviewing that soon, still 1 remark about the discussion surrounding v2: On 1/11/21 2:42 PM, Perry Yuan wrote: <snip> >>> *The flow is like this: >>> 1) User presses key. HW does stuff with this key (timeout is started) >>> 2) Event is emitted from FW >>> 3) Event received by dell-privacy >>> 4) KEY_MICMUTE emitted from dell-privacy >>> 5) Userland picks up key and modifies kcontrol for SW mute >>> 6) Codec kernel driver catches and calls ledtrig_audio_set, like this: >>> ledtrig_audio_set(LED_AUDIO_MICMUTE, >>> rt715->micmute_led ? LED_ON :LED_OFF); >>> 7) If "LED" is set to on dell-privacy notifies ec, >>> and timeout is cancelled,HW mic mute activated. >>> >> Please proofread the commit message again, and pay attention to capitalization >> and spacing. > I want to reformat it and move the commit info to cover letter. Please also put a copy of this as a comment in either the wmi or the acpi driver (with a comment pointing to the comment in the other) this is important info to have for someone reading the code and trying to understand how this all fits together. Regards, Hans
Powered by blists - more mailing lists