linux-kernel - Re: [PATCH net ] net: mvpp2: Remove Pause and Asym

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210111165737.092f02c8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 11 Jan 2021 16:57:37 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     stefanc@...vell.com, netdev@...r.kernel.org,
        thomas.petazzoni@...tlin.com, davem@...emloft.net,
        nadavh@...vell.com, ymarkman@...vell.com,
        linux-kernel@...r.kernel.org, linux@...linux.org.uk,
        mw@...ihalf.com, rmk+kernel@...linux.org.uk, atenart@...nel.org
Subject: Re: [PATCH net ] net: mvpp2: Remove Pause and Asym_Pause support

On Tue, 12 Jan 2021 01:47:27 +0100 Andrew Lunn wrote:
> On Mon, Jan 11, 2021 at 04:36:53PM -0800, Jakub Kicinski wrote:
> > On Sun, 10 Jan 2021 21:23:02 +0200 stefanc@...vell.com wrote:  
> > > From: Stefan Chulski <stefanc@...vell.com>
> > > 
> > > Packet Processor hardware not connected to MAC flow control unit and
> > > cannot support TX flow control.
> > > This patch disable flow control support.
> > > 
> > > Fixes: 3f518509dedc ("ethernet: Add new driver for Marvell Armada 375 network unit")
> > > Signed-off-by: Stefan Chulski <stefanc@...vell.com>  
> > 
> > I'm probably missing something, but why not 4bb043262878 ("net: mvpp2:
> > phylink support")?  
> 
> Hi Jakub
> 
> Before that change, it used phylib. The same is true with phylib, you
> need to tell phylib it should not advertise pause. How you do it is
> different, but the basic issue is the same. Anybody doing a backport
> past 4bb043262878is going to need a different fix, but the basic issue
> is there all the way back to when the driver was added.

Thanks for confirming, I didn't see any code being removed which would
tell phylib pause is supported, so I wanted to make sure phylib
defaults to on / gets it from some register. 

Applied now, thanks!