linux-kernel - Re: [PATCH 0/6] fs: deduplicate compat logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210112005823.GB3579531@ZenIV.linux.org.uk>
Date:   Tue, 12 Jan 2021 00:58:23 +0000
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        akpm@...ux-foundation.org, willy@...radead.org, arnd@...nel.org,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH 0/6] fs: deduplicate compat logic

On Mon, Jan 11, 2021 at 07:30:11PM -0500, Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@...gle.com>
> 
> Use in_compat_syscall() to differentiate compat handling exactly
> where needed, including in nested function calls. Then remove
> duplicated code in callers.

IMO it's a bad idea.  Use of in_compat_syscall() is hard to avoid
in some cases, but let's not use it without a good reason.  It
makes the code harder to reason about.