linux-kernel - Re: [PATCH] clk: mmp2: fix build without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <161047992867.3661239.5060019380091996342@swboyd.mtv.corp.google.com>
Date:   Tue, 12 Jan 2021 11:32:08 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Arnd Bergmann <arnd@...nel.org>, Lubomir Rintel <lkundrak@...sk>,
        Michael Turquette <mturquette@...libre.com>
Cc:     Arnd Bergmann <arnd@...db.de>, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: mmp2: fix build without CONFIG_PM

Quoting Arnd Bergmann (2021-01-03 05:54:53)
> From: Arnd Bergmann <arnd@...db.de>
> 
> pm_clk_suspend()/pm_clk_resume() are defined as NULL pointers rather than
> empty inline stubs without CONFIG_PM:
> 
> drivers/clk/mmp/clk-audio.c:402:16: error: called object type 'void *' is not a function or function pointer
>         pm_clk_suspend(dev);
> drivers/clk/mmp/clk-audio.c:411:15: error: called object type 'void *' is not a function or function pointer
>         pm_clk_resume(dev);
> 
> I tried redefining the helper functions, but that caused additional
> problems. This is the simple solution of replacing the __maybe_unused
> trick with an #ifdef.
> 
> Fixes: 725262d29139 ("clk: mmp2: Add audio clock controller driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

Applied to clk-fixes