linux-kernel - Re: [PATCH v2 08/70] mm/mmap: Change find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf85f917-4f91-8757-8f4f-e8ac5e57a793@infradead.org>
Date:   Tue, 12 Jan 2021 13:01:04 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     "Liam R. Howlett" <Liam.Howlett@...cle.com>,
        maple-tree@...ts.infradead.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Cc:     Andrew Morton <akpm@...gle.com>, Song Liu <songliubraving@...com>,
        Davidlohr Bueso <dave@...olabs.net>,
        "Paul E . McKenney" <paulmck@...nel.org>,
        Matthew Wilcox <willy@...radead.org>,
        Jerome Glisse <jglisse@...hat.com>,
        David Rientjes <rientjes@...gle.com>,
        Axel Rasmussen <axelrasmussen@...gle.com>,
        Suren Baghdasaryan <surenb@...gle.com>,
        Vlastimil Babka <vbabka@...e.cz>,
        Rik van Riel <riel@...riel.com>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH v2 08/70] mm/mmap: Change find_vma() to use the maple tree

Hi,
Please adjust the kernel-doc to be correct :)

On 1/12/21 8:11 AM, Liam R. Howlett wrote:
> Start using the maple tree to find VMA entries in an mm_struct.
> 
> Signed-off-by: Liam R. Howlett <Liam.Howlett@...cle.com>
> ---
>  mm/mmap.c | 29 +++++++++++------------------
>  1 file changed, 11 insertions(+), 18 deletions(-)
> 
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 65789b188c380..ab1cb0efc4c65 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -2474,10 +2474,17 @@ get_unmapped_area(struct file *file, unsigned long addr, unsigned long len,
>  
>  EXPORT_SYMBOL(get_unmapped_area);
>  
> -/* Look up the first VMA which satisfies  addr < vm_end,  NULL if none. */
> +/**
> + * find_vma() - Find the VMA for a given address, or the next vma.  May return
> + * NULL in the case of no vma at addr or above

      %NULL

> + * @mm The mm_struct to check

    * @mm: ...

> + * @addr: The address
> + *
> + * Returns: The VMA assoicated with addr, or the next vma.

                       associated

> + * May return NULL in the case of no vma at addr or above.

                 %NULL

> + */
>  struct vm_area_struct *find_vma(struct mm_struct *mm, unsigned long addr)
>  {


thanks.
-- 
~Randy