linux-kernel - Re: [PATCH 2/2] ASoC: intel: fix soundwire dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cde511d6-fa14-0cab-f00c-f75ad2d8281c@linux.intel.com>
Date:   Tue, 12 Jan 2021 15:03:04 -0600
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Arnd Bergmann <arnd@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Daniel Baluta <daniel.baluta@....com>,
        Mark Brown <broonie@...nel.org>
Cc:     Guennadi Liakhovetski <guennadi.liakhovetski@...ux.intel.com>,
        Cezary Rojewski <cezary.rojewski@...el.com>,
        Arnd Bergmann <arnd@...db.de>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, sound-open-firmware@...a-project.org
Subject: Re: [PATCH 2/2] ASoC: intel: fix soundwire dependencies



On 1/12/21 2:32 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The Kconfig logic around SND_SOC_SOF_INTEL_SOUNDWIRE tries to
> ensure that all sound modules can be built with the minimal
> dependencies, but this fails in some configurations:
> 
> x86_64-linux-ld: sound/hda/intel-dsp-config.o: in function `snd_intel_dsp_driver_probe':
> intel-dsp-config.c:(.text+0x134): undefined reference to `sdw_intel_acpi_scan'
> 
> Specifically, this happens if the dsp-config driver is built-in but does
> not need to use soundwire, while CONFIG_SOUNDWIRE_INTEL is enabled as
> a loadable module.
> 
> An easier and more correct way to do this is to remove
> CONFIG_SND_SOC_SOF_INTEL_SOUNDWIRE_LINK and instead have
> the two drivers that can link against SOUNDWIRE_INTEL,
> i.e. DSP_CONFIG and SND_SOC_SOF_HDA, select that driver whenever
> SND_SOC_SOF_INTEL_SOUNDWIRE_LINK is set.
> 
> This however means that SND_SOC_SOF_INTEL_SOUNDWIRE cannot be selected
> by users when SOUNDWIRE is only usable by loadable modules and one or
> more drivers using SND_SOC_SOF_INTEL_SOUNDWIRE_LINK_BASELINE is built-in.

The problem is real, but the proposal isn't completely right, there is 
absolutely no logical link or functional dependency between 
INTEL_DSP_CONFIG and SOUNDWIRE.

We have a similar case with HDaudio, the two buses can be selected as 
tristates, but the SOF configuration needs to match.

In both cases, either we add a 'depends' and users need to make sure the 
configurations match on the two sides. Or we use select but one of the 
selections will be overridden and becomes meaningless.

Arnd, do you mind if I give it a try on my side?

> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   sound/hda/Kconfig           |  1 +
>   sound/soc/sof/intel/Kconfig | 16 ++++++----------
>   2 files changed, 7 insertions(+), 10 deletions(-)
> 
> diff --git a/sound/hda/Kconfig b/sound/hda/Kconfig
> index 3bc9224d5e4f..ecab814d7698 100644
> --- a/sound/hda/Kconfig
> +++ b/sound/hda/Kconfig
> @@ -44,5 +44,6 @@ config SND_INTEL_NHLT
>   config SND_INTEL_DSP_CONFIG
>   	tristate
>   	select SND_INTEL_NHLT if ACPI
> +	select SOUNDWIRE_INTEL if SND_SOC_SOF_INTEL_SOUNDWIRE
>   	# this config should be selected only for Intel DSP platforms.
>   	# A fallback is provided so that the code compiles in all cases.
> diff --git a/sound/soc/sof/intel/Kconfig b/sound/soc/sof/intel/Kconfig
> index 67365ce0d86d..df8f9760870e 100644
> --- a/sound/soc/sof/intel/Kconfig
> +++ b/sound/soc/sof/intel/Kconfig
> @@ -330,13 +330,17 @@ config SND_SOC_SOF_HDA
>   	tristate
>   	select SND_HDA_EXT_CORE if SND_SOC_SOF_HDA_LINK
>   	select SND_SOC_HDAC_HDA if SND_SOC_SOF_HDA_AUDIO_CODEC
> +	select SOUNDWIRE_INTEL if SND_SOC_SOF_INTEL_SOUNDWIRE
>   	help
>   	  This option is not user-selectable but automagically handled by
>   	  'select' statements at a higher level.
>   
> -config SND_SOC_SOF_INTEL_SOUNDWIRE_LINK
> +config SND_SOC_SOF_INTEL_SOUNDWIRE
>   	bool "SOF support for SoundWire"
> -	depends on SOUNDWIRE && ACPI
> +	depends on SND_SOC_SOF_INTEL_SOUNDWIRE_LINK_BASELINE
> +	depends on SOUNDWIRE
> +	depends on ACPI
> +	depends on !(SOUNDWIRE=m && SND_SOC_SOF_INTEL_SOUNDWIRE_LINK_BASELINE=y)
>   	help
>   	  This adds support for SoundWire with Sound Open Firmware
>   	  for Intel(R) platforms.
> @@ -345,14 +349,6 @@ config SND_SOC_SOF_INTEL_SOUNDWIRE_LINK
>   
>   config SND_SOC_SOF_INTEL_SOUNDWIRE_LINK_BASELINE
>   	tristate
> -	select SND_SOC_SOF_INTEL_SOUNDWIRE if SND_SOC_SOF_INTEL_SOUNDWIRE_LINK
> -	help
> -	  This option is not user-selectable but automagically handled by
> -	  'select' statements at a higher level.
> -
> -config SND_SOC_SOF_INTEL_SOUNDWIRE
> -	tristate
> -	select SOUNDWIRE_INTEL
>   	help
>   	  This option is not user-selectable but automagically handled by
>   	  'select' statements at a higher level.
>