linux-kernel - Re: [PATCH v2 10/70] mm/mmap: Change unmapped_area and unmapped_area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <477569cb-3762-ff89-52b3-10e9cc62f417@infradead.org>
Date:   Tue, 12 Jan 2021 13:05:57 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     "Liam R. Howlett" <Liam.Howlett@...cle.com>,
        maple-tree@...ts.infradead.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Cc:     Andrew Morton <akpm@...gle.com>, Song Liu <songliubraving@...com>,
        Davidlohr Bueso <dave@...olabs.net>,
        "Paul E . McKenney" <paulmck@...nel.org>,
        Matthew Wilcox <willy@...radead.org>,
        Jerome Glisse <jglisse@...hat.com>,
        David Rientjes <rientjes@...gle.com>,
        Axel Rasmussen <axelrasmussen@...gle.com>,
        Suren Baghdasaryan <surenb@...gle.com>,
        Vlastimil Babka <vbabka@...e.cz>,
        Rik van Riel <riel@...riel.com>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH v2 10/70] mm/mmap: Change unmapped_area and
 unmapped_area_topdown to use maple tree

one copy-pasta error below:

On 1/12/21 8:11 AM, Liam R. Howlett wrote:
> Use the new maple tree data structure to find an unmapped area.
> 
> Signed-off-by: Liam R. Howlett <Liam.Howlett@...cle.com>
> ---
>  mm/mmap.c | 249 ++++++------------------------------------------------
>  1 file changed, 27 insertions(+), 222 deletions(-)
> 
> diff --git a/mm/mmap.c b/mm/mmap.c
> index f123f9c97dfe8..3b3084ee309b7 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -2040,260 +2040,65 @@ unsigned long mmap_region(struct file *file, unsigned long addr,
>  	return error;
>  }
>  
> +/* unmapped_area() Find an area between the low_limit and the high_limit with
> + * the correct alignment and offset, all from @info. Note: current->mm is used
> + * for the search.
> + *
> + * @info: The unmapped area information including the range (low_limit -
> + * hight_limit), the alignment offset and mask.
> + *
> + * Return: A memory address or -ENOMEM.
> + */
>  static unsigned long unmapped_area(struct vm_unmapped_area_info *info)
>  {
...
>  }
>  
> +/* unmapped_area() Find an area between the low_limit and the high_limit with

s/unmapped_area/unmapped_area_topdown/

> + * the correct alignment and offset at the highest available address, all from
> + * @info. Note: current->mm is used for the search.
> + *
> + * @info: The unmapped area information including the range (low_limit -
> + * hight_limit), the alignment offset and mask.
> + *
> + * Return: A memory address or -ENOMEM.
> + */
>  static unsigned long unmapped_area_topdown(struct vm_unmapped_area_info *info)
>  {

thanks.
-- 
~Randy