[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CADnq5_N40DL6=VKXA89kbTH-h=AoZ3HTJm3L2yqa0=V8v05eiA@mail.gmail.com>
Date: Tue, 12 Jan 2021 17:06:16 -0500
From: Alex Deucher <alexdeucher@...il.com>
To: Lee Jones <lee.jones@...aro.org>
Cc: Leo Li <sunpeng.li@....com>, LKML <linux-kernel@...r.kernel.org>,
amd-gfx list <amd-gfx@...ts.freedesktop.org>,
David Airlie <airlied@...ux.ie>,
Maling list - DRI developers
<dri-devel@...ts.freedesktop.org>,
Alex Deucher <alexander.deucher@....com>,
Christian König <christian.koenig@....com>
Subject: Re: [PATCH 10/40] drm/amd/display/dc/dce120/dce120_hw_sequencer:
Encompass defines in same clause as their use
On Mon, Jan 11, 2021 at 2:19 PM Lee Jones <lee.jones@...aro.org> wrote:
>
> Ideally someone should strip-out all these garbage 'if 0's.
>
> Tempted to carry out the work myself on principle!
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_hw_sequencer.c:53:47: warning: ‘reg_offsets’ defined but not used [-Wunused-const-variable=]
>
> Cc: Harry Wentland <harry.wentland@....com>
> Cc: Leo Li <sunpeng.li@....com>
> Cc: Alex Deucher <alexander.deucher@....com>
> Cc: "Christian König" <christian.koenig@....com>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: amd-gfx@...ts.freedesktop.org
> Cc: dri-devel@...ts.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
Applied. Thanks!
Alex
> ---
> drivers/gpu/drm/amd/display/dc/dce120/dce120_hw_sequencer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce120/dce120_hw_sequencer.c
> index 66a13aa39c951..d4afe6c824d2c 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_hw_sequencer.c
> @@ -50,6 +50,7 @@ struct dce120_hw_seq_reg_offsets {
> uint32_t crtc;
> };
>
> +#if 0
> static const struct dce120_hw_seq_reg_offsets reg_offsets[] = {
> {
> .crtc = (mmCRTC0_CRTC_GSL_CONTROL - mmCRTC0_CRTC_GSL_CONTROL),
> @@ -79,7 +80,6 @@ static const struct dce120_hw_seq_reg_offsets reg_offsets[] = {
> /*******************************************************************************
> * Private definitions
> ******************************************************************************/
> -#if 0
> static void dce120_init_pte(struct dc_context *ctx, uint8_t controller_id)
> {
> uint32_t addr;
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Powered by blists - more mailing lists