linux-kernel - Re: [PATCH] net: macb: Add default usrio config to default gem config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20f0b8567d27aead1f844ab863551d2a495474ce.camel@wdc.com>
Date:   Tue, 12 Jan 2021 01:48:06 +0000
From:   Atish Patra <Atish.Patra@....com>
To:     "kuba@...nel.org" <kuba@...nel.org>
CC:     "nicolas.ferre@...rochip.com" <nicolas.ferre@...rochip.com>,
        "claudiu.beznea@...rochip.com" <claudiu.beznea@...rochip.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: macb: Add default usrio config to default gem config

On Mon, 2021-01-11 at 15:13 -0800, Jakub Kicinski wrote:
> On Mon, 11 Jan 2021 11:55:53 -0800 Atish Patra wrote:
> > There is no usrio config defined for default gem config leading to
> > a kernel panic devices that don't define a data. This issue can be
> > reprdouced with microchip polar fire soc where compatible string
> > is defined as "cdns,macb".
> > 
> > Fixes: edac63861db7 ("add userio bits as platform configuration")
> > 
> > Signed-off-by: Atish Patra <atish.patra@....com>
> 
> Fixes tag needs work:
> 
> Fixes tag: Fixes: edac63861db7 ("add userio bits as platform
> configuration")
> Has these problem(s):
>         - empty line after the tag
>         - Subject does not match target commit subject
>           Just use
>                 git log -1 --format='Fixes: %h ("%s")'
> 
> Please put [PATCH net] as subject prefix, to indicate this 
> is a networking fix.
> 
> You can also CC Andrew Lunn like get_maintainer.pl suggests,
> but drop linux-kernel from the CC/To.

Done. Thanks for the feedback.

-- 
Regards,
Atish