linux-kernel - [PATCH v2] USB:ehci:fix an interrupt calltrace error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1610416647-45774-1-git-send-email-liulongfang@huawei.com>
Date:   Tue, 12 Jan 2021 09:57:27 +0800
From:   Longfang Liu <liulongfang@...wei.com>
To:     <gregkh@...uxfoundation.org>, <stern@...land.harvard.edu>
CC:     <linux-usb@...r.kernel.org>, <yisen.zhuang@...wei.com>,
        <kong.kongxinwei@...ilicon.com>, <linux-kernel@...r.kernel.org>
Subject: [PATCH v2] USB:ehci:fix an interrupt calltrace error

The system that use Synopsys USB host controllers goes to suspend
when using USB audio player. This causes the USB host controller
continuous send interrupt signal to system, When the number of
interrupts exceeds 100000, the system will forcibly close the
interrupts and output a calltrace error.

When the system goes to suspend, the last interrupt is reported to
the driver. At this time, the system has set the state to suspend.
This causes the last interrupt to not be processed by the system and
not clear the interrupt flag. This uncleared interrupt flag constantly
triggers new interrupt event. This causing the driver to receive more
than 100,000 interrupts, which causes the system to forcibly close the
interrupt report and report the calltrace error.

so, when the driver goes to sleep and changes the system state to
suspend, the interrupt flag needs to be cleared.

Signed-off-by: Longfang Liu <liulongfang@...wei.com>
Acked-by: Alan Stern <stern@...land.harvard.edu>
---

Changes in v2:
- updated cleared registers

 drivers/usb/host/ehci-hub.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c
index ce0eaf7..6dfbba1 100644
--- a/drivers/usb/host/ehci-hub.c
+++ b/drivers/usb/host/ehci-hub.c
@@ -346,6 +346,9 @@ static int ehci_bus_suspend (struct usb_hcd *hcd)

 	unlink_empty_async_suspended(ehci);

+	/* Some Synopsys controllers mistakenly leave IAA turned on */
+	ehci_writel(ehci, STS_IAA, &ehci->regs->status);
+
 	/* Any IAA cycle that started before the suspend is now invalid */
 	end_iaa_cycle(ehci);
 	ehci_handle_start_intr_unlinks(ehci);
-- 
2.8.1