lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 11 Jan 2021 19:43:57 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Lubomir Rintel <lkundrak@...sk>
Cc:     Souptick Joarder <jrdr.linux@...il.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input: ariel-pwrbutton.c: Remove unused variable
 ariel_pwrbutton_id_table[]

On Tue, Jan 12, 2021 at 04:20:28AM +0100, Lubomir Rintel wrote:
> On Mon, Jan 04, 2021 at 02:02:13PM -0800, Dmitry Torokhov wrote:
> > On Tue, Dec 29, 2020 at 01:15:10PM +0530, Souptick Joarder wrote:
> > > On Tue, Dec 22, 2020 at 1:34 AM Souptick Joarder <jrdr.linux@...il.com> wrote:
> > > >
> > > > Kernel test robot throws below warning ->
> > > >
> > > > >> drivers/input/misc/ariel-pwrbutton.c:152:35: warning: unused variable
> > > > >> 'ariel_pwrbutton_id_table' [-Wunused-const-variable]
> > > >    static const struct spi_device_id ariel_pwrbutton_id_table[] = {
> > > >                                      ^
> > > >    1 warning generated.
> > > >
> > > > Remove unused variable ariel_pwrbutton_id_table[] if no plan to use
> > > > it further.
> > > >
> > > > Reported-by: kernel test robot <lkp@...el.com>
> > > > Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>
> > > 
> > > Any comment on this patch ?
> > 
> > Lubomir, would you prefer to remove the table or add it to the driver
> > structure as ariel_pwrbutton_driver->id_table?
> 
> I believe it can be safely dropped, as the OF match seems to be
> sufficient.
> 
> Thank you for the patch Souptick.
> 
> Reviewed-by: Lubomir Rintel <lkundrak@...sk>

Applied, thank you.

-- 
Dmitry

Powered by blists - more mailing lists