linux-kernel - Re: [PATCH] input: auo_pixcir_ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <X/0utdv13PT0ipTs@google.com>
Date:   Mon, 11 Jan 2021 21:08:05 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Radim Pavlik <radim.pavlik@...-biometrics.com>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        Heiko Stuebner <heiko@...ech.de>
Subject: Re: [PATCH] input: auo_pixcir_ts - add missing check for gpio

Hi Radim,

On Thu, Jan 07, 2021 at 10:32:17AM +0100, Radim Pavlik wrote:
> The of_get_gpio() may return error, so check it immediately. The old
> code might fail with EPROBE_DEFER which was masked by the
> folowing gpio_is_valid() and returned EINVAL.
> 
> Signed-off-by: Radim Pavlik <radim.pavlik@...-biometrics.com>
> ---
>  drivers/input/touchscreen/auo-pixcir-ts.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/input/touchscreen/auo-pixcir-ts.c b/drivers/input/touchscreen/auo-pixcir-ts.c
> index c33e63ca6142..8f3cfd743bdd 100644
> --- a/drivers/input/touchscreen/auo-pixcir-ts.c
> +++ b/drivers/input/touchscreen/auo-pixcir-ts.c
> @@ -479,12 +479,16 @@ static struct auo_pixcir_ts_platdata *auo_pixcir_parse_dt(struct device *dev)
>  		return ERR_PTR(-ENOMEM);
>  
>  	pdata->gpio_int = of_get_gpio(np, 0);
> +	if (pdata->gpio_int < 0)
> +		return ERR_PTR(pdata->gpio_int);

Hmm, while this check might make sense it definitely renders the next
one unnecessary.

BTW, do you have a device that uses this touch panel? This driver could
use more improvements, such as switching to gpiod API and generic device
properties, and dropping the platform data support.

Thanks.

-- 
Dmitry