linux-kernel - Re: [PATCH 5/6] compat: add set_maybe_compat_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202101121556.nOcZaHpL-lkp@intel.com>
Date:   Tue, 12 Jan 2021 15:11:51 +0800
From:   kernel test robot <lkp@...el.com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        linux-fsdevel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        viro@...iv.linux.org.uk, akpm@...ux-foundation.org,
        willy@...radead.org, arnd@...nel.org,
        Willem de Bruijn <willemb@...gle.com>,
        Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH 5/6] compat: add set_maybe_compat_user_sigmask helper

Hi Willem,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on kselftest/next]
[also build test ERROR on linus/master v5.11-rc3 next-20210111]
[cannot apply to linux/master hnaz-linux-mm/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Willem-de-Bruijn/fs-deduplicate-compat-logic/20210112-083603
base:   https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next
config: powerpc64-randconfig-r034-20210111 (attached as .config)
compiler: powerpc-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/b49b48b376694f2a27d3c494f2bf638d0c8f7650
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Willem-de-Bruijn/fs-deduplicate-compat-logic/20210112-083603
        git checkout b49b48b376694f2a27d3c494f2bf638d0c8f7650
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from arch/powerpc/kernel/asm-offsets.c:14:
   include/linux/compat.h: In function 'set_maybe_compat_user_sigmask':
>> include/linux/compat.h:952:10: error: implicit declaration of function 'set_compat_user_sigmask'; did you mean 'set_maybe_compat_user_sigmask'? [-Werror=implicit-function-declaration]
     952 |   return set_compat_user_sigmask(umask, sigsetsize);
         |          ^~~~~~~~~~~~~~~~~~~~~~~
         |          set_maybe_compat_user_sigmask
   cc1: some warnings being treated as errors
--
   WARNING: unmet direct dependencies detected for NET_DEVLINK
   Depends on NET
   Selected by
   - BNXT && NETDEVICES && ETHERNET && NET_VENDOR_BROADCOM && PCI
   - NFP && NETDEVICES && ETHERNET && NET_VENDOR_NETRONOME && PCI && PCI_MSI && (VXLAN || VXLAN && (TLS && TLS_DEVICE || !TLS_DEVICE
   In file included from arch/powerpc/kernel/asm-offsets.c:14:
   include/linux/compat.h: In function 'set_maybe_compat_user_sigmask':
>> include/linux/compat.h:952:10: error: implicit declaration of function 'set_compat_user_sigmask'; did you mean
   952 | return set_compat_user_sigmask(umask, sigsetsize);
   | ^~~~~~~~~~~~~~~~~~~~~~~
   | set_maybe_compat_user_sigmask
   cc1: some warnings being treated as errors
   Makefile arch include kernel scripts source usr [scripts/Makefile.build:117: arch/powerpc/kernel/asm-offsets.s] Error 1
   Target '__build' not remade because of errors.
   Makefile arch include kernel scripts source usr [Makefile:1206: prepare0] Error 2
   Target 'prepare' not remade because of errors.
   make: Makefile arch include kernel scripts source usr [Makefile:185: __sub-make] Error 2
   make: Target 'prepare' not remade because of errors.

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for NETDEVICES
   Depends on NET
   Selected by
   - AKEBONO && PPC_47x
   WARNING: unmet direct dependencies detected for ETHERNET
   Depends on NETDEVICES && NET
   Selected by
   - AKEBONO && PPC_47x
   WARNING: unmet direct dependencies detected for FAILOVER
   Depends on NET
   Selected by
   - NET_FAILOVER && NETDEVICES
   WARNING: unmet direct dependencies detected for PAGE_POOL
   Depends on NET
   Selected by
   - BNXT && NETDEVICES && ETHERNET && NET_VENDOR_BROADCOM && PCI
   WARNING: unmet direct dependencies detected for NET_DEVLINK
   Depends on NET
   Selected by
   - BNXT && NETDEVICES && ETHERNET && NET_VENDOR_BROADCOM && PCI
   - NFP && NETDEVICES && ETHERNET && NET_VENDOR_NETRONOME && PCI && PCI_MSI && (VXLAN || VXLAN && (TLS && TLS_DEVICE || !TLS_DEVICE


vim +/set_compat_user_sigmask +952 include/linux/compat.h

   945	
   946	static inline int set_maybe_compat_user_sigmask(const void __user *umask,
   947							size_t sigsetsize)
   948	{
   949		if (!in_compat_syscall())
   950			return set_user_sigmask(umask, sigsetsize);
   951		else
 > 952			return set_compat_user_sigmask(umask, sigsetsize);
   953	}
   954	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (26622 bytes)