linux-kernel - Re: [PATCH 1/2] init/main.c: fix strings split across lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210111190235.3e81770f@gandalf.local.home>
Date:   Mon, 11 Jan 2021 19:02:35 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Liu Peibao <liupeibao@....com>
Cc:     mhiramat@...nel.org, akpm@...ux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] init/main.c: fix strings split across lines

On Wed, 30 Dec 2020 14:04:23 +0800
Liu Peibao <liupeibao@....com> wrote:

> Fix warning found by checkpatch.pl.
> 
> Signed-off-by: Liu Peibao <liupeibao@....com>
> ---
>  init/main.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/init/main.c b/init/main.c
> index 6feee7f11eaf..1e492de770c8 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -1470,8 +1470,7 @@ static int __ref kernel_init(void *unused)
>  	    !try_to_run_init_process("/bin/sh"))
>  		return 0;
>  
> -	panic("No working init found.  Try passing init= option to kernel. "
> -	      "See Linux Documentation/admin-guide/init.rst for guidance.");
> +	panic("No working init found. Try passing init= option to kernel. See Linux Documentation/admin-guide/init.rst for guidance.");

Sorry, we don't add changes to the kernel that checkpatch warns about.
checkpatch should only be run on new code. Please do not submit any patches
on existing code because checkpatch warns about it.

-- Steve


>  }
>  
>  /* Open /dev/console, for stdin/stdout/stderr, this should never fail */