lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 Jan 2021 23:43:05 +0100 From: Thomas Bogendoerfer <tsbogend@...ha.franken.de> To: Alexander Lobakin <alobakin@...me> Cc: Kees Cook <keescook@...omium.org>, Arnd Bergmann <arnd@...db.de>, Nathan Chancellor <natechancellor@...il.com>, Nick Desaulniers <ndesaulniers@...gle.com>, Huacai Chen <chenhuacai@...nel.org>, Pei Huang <huangpei@...ngson.cn>, Fangrui Song <maskray@...gle.com>, Jiaxun Yang <jiaxun.yang@...goat.com>, Ralf Baechle <ralf@...ux-mips.org>, Corey Minyard <cminyard@...sta.com>, linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org, stable@...r.kernel.org, clang-built-linux@...glegroups.com Subject: Re: [PATCH v5 mips-next 0/9] MIPS: vmlinux.lds.S sections fixes & cleanup On Mon, Jan 11, 2021 at 08:57:25PM +0000, Alexander Lobakin wrote: > From: Kees Cook <keescook@...omium.org> > Date: Mon, 11 Jan 2021 11:53:39 -0800 > > > On Sun, Jan 10, 2021 at 11:53:50AM +0000, Alexander Lobakin wrote: > >> This series hunts the problems discovered after manual enabling of > >> ARCH_WANT_LD_ORPHAN_WARN. Notably: > >> - adds the missing PAGE_ALIGNED_DATA() section affecting VDSO > >> placement (marked for stable); > >> - stops blind catching of orphan text sections with .text.* > >> directive; > >> - properly stops .eh_frame section generation. > >> > >> Compile and runtime tested on MIPS32R2 CPS board with no issues > >> using two different toolkits: > >> - Binutils 2.35.1, GCC 10.2.1 (with Alpine patches); > >> - LLVM stack: 11.0.0 and from latest Git snapshot. > >> > >> Since v4 [3]: > >> - new: drop redundant .text.cps-vec creation and blind inclusion > >> of orphan text sections via .text.* directive in vmlinux.lds.S; > >> - don't assert SIZEOF(.rel.dyn) as it's reported that it may be not > >> empty on certain machines and compilers (Thomas); > >> - align GOT table like it's done for ARM64; > >> - new: catch UBSAN's "unnamed data" sections in generic definitions > >> when building with LD_DEAD_CODE_DATA_ELIMINATION; > >> - collect Reviewed-bys (Kees, Nathan). > > > > Looks good; which tree will this land through? > > linux-mips/mips-next I guess, since 7 of 9 patches are related only > to this architecture. > This might need Arnd's Acked-bys or Reviewed-by for the two that > refer include/asm-generic, let's see what Thomas think. Looks good from my side and I have it already sitting in branch for submission. Arnd, are you ok with the changes in include/asm-generic ? Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
Powered by blists - more mailing lists