lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [day] [month] [year] [list]
Date:   Tue, 12 Jan 2021 14:46:47 +0530
From:   Bhaskar Chowdhury <unixbhaskar@...il.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     mw@...ihalf.com, linux@...linux.org.uk, davem@...emloft.net,
        kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, rdunlap@...radead.org
Subject: Re: [PATCH V2] drivers: net: marvell: Fix two spellings, controling
 to controlling and oen to one

On 23:20 Mon 11 Jan 2021, Gustavo A. R. Silva wrote:
>
>
>On 1/11/21 23:13, Bhaskar Chowdhury wrote:
>> s/controling/controlling/
>>
>> s/oen/one/
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@...il.com>
>> ---
>>  As Gustavo mentioned in reply, so included that missed one before
>
>This is not how you version patches for maintainers and reviewers to
>know you made changes to the patch.
>
Ahhh... Recollects my faint memory about it ...let me try again with that


>I encourage you to take a look at this to see examples on how to properly
>version your patches and other good practices:
>
>https://kernelnewbies.org/Outreachyfirstpatch
>
>--
>Gustavo
>
>>
>>  drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.h b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.h
>> index 8867f25afab4..663157dc8062 100644
>> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.h
>> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.h
>> @@ -143,7 +143,7 @@ struct mvpp2_cls_c2_entry {
>>  /* Number of per-port dedicated entries in the C2 TCAM */
>>  #define MVPP22_CLS_C2_PORT_N_FLOWS	MVPP2_N_RFS_ENTRIES_PER_FLOW
>>
>> -/* Each port has oen range per flow type + one entry controling the global RSS
>> +/* Each port has one range per flow type + one entry controlling the global RSS
>>   * setting and the default rx queue
>>   */
>>  #define MVPP22_CLS_C2_PORT_RANGE	(MVPP22_CLS_C2_PORT_N_FLOWS + 1)
>> --
>> 2.26.2
>>

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)

Powered by blists - more mailing lists