linux-kernel - Re: [PATCH] edac: remove redundant error print in xgene_edac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <X/1p7RgQQ+a+ndqZ@rric.localdomain>
Date:   Tue, 12 Jan 2021 10:20:45 +0100
From:   Robert Richter <rric@...nel.org>
To:     menglong8.dong@...il.com
Cc:     khuong@...amperecomputing.com, bp@...en8.de, mchehab@...nel.org,
        tony.luck@...el.com, james.morse@....com,
        linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
        Menglong Dong <dong.menglong@....com.cn>
Subject: Re: [PATCH] edac: remove redundant error print in xgene_edac_probe

On 12.01.21 00:46:05, menglong8.dong@...il.com wrote:
> From: Menglong Dong <dong.menglong@....com.cn>
> 
> Coccinelle reports a redundant error print in xgene_edac_probe.
> As 'platform_get_irq' already prints the error message, error
> print here is redundant and can be removed.
> 
> Signed-off-by: Menglong Dong <dong.menglong@....com.cn>
> ---
>  drivers/edac/xgene_edac.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/edac/xgene_edac.c b/drivers/edac/xgene_edac.c
> index 1d2c27a00a4a..1d583f0ea4dc 100644
> --- a/drivers/edac/xgene_edac.c
> +++ b/drivers/edac/xgene_edac.c
> @@ -1918,7 +1918,6 @@ static int xgene_edac_probe(struct platform_device *pdev)
>  		for (i = 0; i < 3; i++) {
>  			irq = platform_get_irq(pdev, i);
>  			if (irq < 0) {
> -				dev_err(&pdev->dev, "No IRQ resource\n");

Better call platform_get_irq_optional() instead. That would keep the
same error message patterns for all error paths of the probe function.

-Robert

>  				rc = -EINVAL;
>  				goto out_err;
>  			}
> -- 
> 2.17.1
>