linux-kernel - Re: [PATCH v2] i2c: tegra-bpmp: ignore DMA safe buffer flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5003e6eb-4048-edae-adb3-19711a96e9c7@kapsi.fi>
Date:   Tue, 12 Jan 2021 12:27:17 +0200
From:   Mikko Perttunen <cyndis@...si.fi>
To:     Wolfram Sang <wsa@...nel.org>,
        Mikko Perttunen <mperttunen@...dia.com>,
        thierry.reding@...il.com, jonathanh@...dia.com, talho@...dia.com,
        linux-i2c@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org, Muhammed Fazal <mfazale@...dia.com>,
        stable@...r.kernel.org
Subject: Re: [PATCH v2] i2c: tegra-bpmp: ignore DMA safe buffer flag

On 1/12/21 12:26 PM, Wolfram Sang wrote:
> 
>>> I wonder if bailing out on an unknown flag shouldn't be revisited in
>>> general? I mean this will happen again when a new I2C_M_* flag is
>>> introduced.
>>>
>>
>> If it's guaranteed that any new flags are optional to handle by the driver,
>> than that is certainly better. I'll post a v3 with that approach.
> 
> If there will be a new flag, it is highly likely that it will handle
> some corner case which only gets applied when there is a I2C_FUNC_* flag
> guarding it. If the new flag turns out to be mandatory, the (poor)
> author needs to check with all existing drivers anyhow.
> 

Yep, I suppose that is true :)

I just sent out the v3.

thanks!
Mikko