lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 12 Jan 2021 11:10:29 +0000 From: Kieran Bingham <kieran.bingham+renesas@...asonboard.com> To: Ricardo Ribalda <ribalda@...omium.org>, linux-media@...r.kernel.org, linux-kernel@...r.kernel.org Cc: Maxime Ripard <mripard@...nel.org>, Chen-Yu Tsai <wens@...e.org> Subject: Re: [PATCH 6/9] media: sum4i-csi: Do not zero reserved fields Hi Ricardo, Well I've started, so I may as well finish and do the rest too. On 11/01/2021 14:54, Ricardo Ribalda wrote: > Core code already clears reserved fields of struct > v4l2_pix_format_mplane, check: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero > v4l2_plane_pix_format reserved fields"). Indeed, these are the only memsets here ... With the $TITLE fixed as spotted by Ezequiel, Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com> > > Cc: Maxime Ripard <mripard@...nel.org> > Cc: Chen-Yu Tsai <wens@...e.org> > Signed-off-by: Ricardo Ribalda <ribalda@...omium.org> > --- > drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c b/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c > index 1a2f65d83a6c..4785faddf630 100644 > --- a/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c > +++ b/drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c > @@ -113,8 +113,6 @@ static void _sun4i_csi_try_fmt(struct sun4i_csi *csi, > pix->num_planes = _fmt->num_planes; > pix->pixelformat = _fmt->fourcc; > > - memset(pix->reserved, 0, sizeof(pix->reserved)); > - > /* Align the width and height on the subsampling */ > width = ALIGN(pix->width, _fmt->hsub); > height = ALIGN(pix->height, _fmt->vsub); > @@ -131,8 +129,6 @@ static void _sun4i_csi_try_fmt(struct sun4i_csi *csi, > bpl = pix->width / hsub * _fmt->bpp[i] / 8; > pix->plane_fmt[i].bytesperline = bpl; > pix->plane_fmt[i].sizeimage = bpl * pix->height / vsub; > - memset(pix->plane_fmt[i].reserved, 0, > - sizeof(pix->plane_fmt[i].reserved)); > } > } > >
Powered by blists - more mailing lists