linux-kernel - Re: [PATCH] scsi: libsas and users: Remove notifier indirection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X/2HDUmb8L8LPELG@lx-t490>
Date:   Tue, 12 Jan 2021 12:25:01 +0100
From:   "Ahmed S. Darwish" <a.darwish@...utronix.de>
To:     John Garry <john.garry@...wei.com>
Cc:     jejb@...ux.ibm.com, martin.petersen@...cle.com,
        artur.paszkiewicz@...el.com, jinpu.wang@...ud.ionos.com,
        corbet@....net, yanaijie@...wei.com, bigeasy@...utronix.de,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        intel-linux-scu@...el.com, linux-doc@...r.kernel.org
Subject: Re: [PATCH] scsi: libsas and users: Remove notifier indirection

Hi John,

On Tue, Jan 12, 2021 at 01:28:32AM +0800, John Garry wrote:
> LLDDs report events to libsas with .notify_port_event and
> .notify_phy_event callbacks.
>
> These callbacks are fixed and so there is no reason why the functions
> cannot be called directly, so do that.
>
> This neatens the code slightly, makes it more obvious, and reduces
> function pointer usage, which is generally a good thing. Downside is that
> there are 2x more symbol exports.
>
> Signed-off-by: John Garry <john.garry@...wei.com>
>

Since this patch necessitates a careful manual rebase of _every_ patch
in my series, I've included it at the top of my v2 submission and
rebased everything on top:

    https://lkml.kernel.org/r/20210112110647.627783-1-a.darwish@linutronix.de

Some left-over 'sas_ha' local variables were removed, and I've mentioned
that in the commit log of course.

Thanks!

--
Ahmed S. Darwish
Linutronix GmbH