linux-kernel - Re: [PATCH v2] edac: remove redundant error print in xgene_edac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X/2Krblq/iPY3pQe@rric.localdomain>
Date:   Tue, 12 Jan 2021 12:40:29 +0100
From:   Robert Richter <rric@...nel.org>
To:     menglong8.dong@...il.com
Cc:     khuong@...amperecomputing.com, bp@...en8.de, mchehab@...nel.org,
        tony.luck@...el.com, james.morse@....com,
        linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
        Menglong Dong <dong.menglong@....com.cn>
Subject: Re: [PATCH v2] edac: remove redundant error print in xgene_edac_probe

On 12.01.21 02:35:40, menglong8.dong@...il.com wrote:
> From: Menglong Dong <dong.menglong@....com.cn>
> 
> Coccinelle reports a redundant error print in xgene_edac_probe.
> As 'platform_get_irq' already prints the error message, error
> print here is redundant.
> 
> Fix it by using 'platform_get_irq_optional' in place of
> 'platform_get_irq', as Robert suggested.
> 
> Signed-off-by: Menglong Dong <dong.menglong@....com.cn>
> ---
> v2:
> - use 'platform_get_irq_optional' instead of 'platform_get_irq'
> ---

Reviewed-by: Robert Richter <rric@...nel.org>