lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 Jan 2021 15:04:43 -0800 From: Mike Kravetz <mike.kravetz@...cle.com> To: Muchun Song <songmuchun@...edance.com>, akpm@...ux-foundation.org Cc: n-horiguchi@...jp.nec.com, ak@...ux.intel.com, mhocko@...e.cz, linux-mm@...ck.org, linux-kernel@...r.kernel.org, stable@...r.kernel.org Subject: Re: [PATCH v3 2/6] mm: hugetlbfs: fix cannot migrate the fallocated HugeTLB page On 1/10/21 4:40 AM, Muchun Song wrote: > If a new hugetlb page is allocated during fallocate it will not be > marked as active (set_page_huge_active) which will result in a later > isolate_huge_page failure when the page migration code would like to > move that page. Such a failure would be unexpected and wrong. > > Only export set_page_huge_active, just leave clear_page_huge_active > as static. Because there are no external users. > > Fixes: 70c3547e36f5 (hugetlbfs: add hugetlbfs_fallocate()) > Signed-off-by: Muchun Song <songmuchun@...edance.com> > Cc: stable@...r.kernel.org > --- > fs/hugetlbfs/inode.c | 3 ++- > include/linux/hugetlb.h | 2 ++ > mm/hugetlb.c | 2 +- > 3 files changed, 5 insertions(+), 2 deletions(-) Thanks. Although page_huge_active is declared in page-flags.h, I much prefer the declaration of set_page_huge_active to be in hugetlb.c. Reviewed-by: Mike Kravetz <mike.kravetz@...cle.com> -- Mike Kravetz
Powered by blists - more mailing lists