linux-kernel - Re: [PATCH 1/9] media: ipu3-cio2: Do not zero reserved fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Jan 2021 11:58:03 +0000
From:   Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
To:     Ricardo Ribalda <ribalda@...omium.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Sakari Ailus <sakari.ailus@...ux.intel.com>
Subject: Re: [PATCH 1/9] media: ipu3-cio2: Do not zero reserved fields

Hi Ricardo,

On 11/01/2021 14:54, Ricardo Ribalda wrote:
> Core code already clears reserved fields of struct
> v4l2_pix_format_mplane, check: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero
> v4l2_plane_pix_format reserved fields").
> 
> Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>
> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>

> ---
>  drivers/media/pci/intel/ipu3/ipu3-cio2.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> index 36e354ecf71e..c5376de8cb8a 100644
> --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.c
> @@ -1094,12 +1094,9 @@ static int cio2_v4l2_try_fmt(struct file *file, void *fh, struct v4l2_format *f)
>  	mpix->pixelformat = fmt->fourcc;
>  	mpix->colorspace = V4L2_COLORSPACE_RAW;
>  	mpix->field = V4L2_FIELD_NONE;
> -	memset(mpix->reserved, 0, sizeof(mpix->reserved));
>  	mpix->plane_fmt[0].bytesperline = cio2_bytesperline(mpix->width);
>  	mpix->plane_fmt[0].sizeimage = mpix->plane_fmt[0].bytesperline *
>  							mpix->height;
> -	memset(mpix->plane_fmt[0].reserved, 0,
> -	       sizeof(mpix->plane_fmt[0].reserved));
>  
>  	/* use default */
>  	mpix->ycbcr_enc = V4L2_YCBCR_ENC_DEFAULT;
>