lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 12 Jan 2021 00:10:58 +0100 From: Bean Huo <huobean@...il.com> To: alim.akhtar@...sung.com, avri.altman@....com, john.garry@...wei.com, jejb@...ux.ibm.com, martin.petersen@...cle.com, ebiggers@...gle.com, satyat@...gle.com, shipujin.t@...il.com Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, Bean Huo <beanhuo@...ron.com> Subject: [PATCH v2 2/2] scsi: ufs: Remove unnecessary devm_kfree From: Bean Huo <beanhuo@...ron.com> The memory allocated with devm_kzalloc() is freed automatically no need to explicitly call devm_kfree. Reviewed-by: Eric Biggers <ebiggers@...gle.com> Signed-off-by: Bean Huo <beanhuo@...ron.com> --- drivers/scsi/ufs/ufshcd-crypto.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd-crypto.c b/drivers/scsi/ufs/ufshcd-crypto.c index 07310b12a5dc..ec80ec83cf85 100644 --- a/drivers/scsi/ufs/ufshcd-crypto.c +++ b/drivers/scsi/ufs/ufshcd-crypto.c @@ -182,7 +182,7 @@ int ufshcd_hba_init_crypto_capabilities(struct ufs_hba *hba) err = blk_ksm_init(&hba->ksm, hba->crypto_capabilities.config_count + 1); if (err) - goto out_free_caps; + goto out; hba->ksm.ksm_ll_ops = ufshcd_ksm_ops; /* UFS only supports 8 bytes for any DUN */ @@ -208,8 +208,6 @@ int ufshcd_hba_init_crypto_capabilities(struct ufs_hba *hba) return 0; -out_free_caps: - devm_kfree(hba->dev, hba->crypto_cap_array); out: /* Indicate that init failed by clearing UFSHCD_CAP_CRYPTO */ hba->caps &= ~UFSHCD_CAP_CRYPTO; -- 2.17.1
Powered by blists - more mailing lists