linux-kernel - Re: [PATCH 1/2] dmaengine: fsldma: Fix a resource leak in the remove function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210112123057.GS2771@vkoul-mobl>
Date:   Tue, 12 Jan 2021 18:00:57 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     leoyang.li@....com, zw@...kernel.org, dan.j.williams@...el.com,
        timur@...escale.com, linuxppc-dev@...ts.ozlabs.org,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/2] dmaengine: fsldma: Fix a resource leak in the remove
 function

On 12-12-20, 17:05, Christophe JAILLET wrote:
> A 'irq_dispose_mapping()' call is missing in the remove function.
> Add it.
> 
> This is needed to undo the 'irq_of_parse_and_map() call from the probe
> function and already part of the error handling path of the probe function.
> 
> It was added in the probe function only in commit d3f620b2c4fe ("fsldma:
> simplify IRQ probing and handling")

Applied both, thanks

-- 
~Vinod