linux-kernel - Re: mmotm 2021-01-12-01-57 uploaded (NR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ef78ccc-ab9e-5a18-ced7-ed2e993e4fef@infradead.org>
Date:   Tue, 12 Jan 2021 14:20:00 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     broonie@...nel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-next@...r.kernel.org, mhocko@...e.cz,
        mm-commits@...r.kernel.org, sfr@...b.auug.org.au,
        Shakeel Butt <shakeelb@...gle.com>
Subject: Re: mmotm 2021-01-12-01-57 uploaded (NR_SWAPCACHE in mm/)

On 1/12/21 1:50 PM, Andrew Morton wrote:

>>
>> on i386 and x86_64:
>>
>> when CONFIG_SWAP is not set/enabled:
>>
>> ../mm/migrate.c: In function ‘migrate_page_move_mapping’:
>> ../mm/migrate.c:504:35: error: ‘NR_SWAPCACHE’ undeclared (first use in this function); did you mean ‘QC_SPACE’?
>>     __mod_lruvec_state(old_lruvec, NR_SWAPCACHE, -nr);
>>                                    ^~~~~~~~~~~~
>>
>> ../mm/memcontrol.c:1529:20: error: ‘NR_SWAPCACHE’ undeclared here (not in a function); did you mean ‘SGP_CACHE’?
>>   { "swapcached",   NR_SWAPCACHE   },
>>                     ^~~~~~~~~~~~
> 
> Thanks.  I did the below.

WorsForMe. Thanks.

Acked-by: Randy Dunlap <rdunlap@...radead.org>


> But we're still emitting "Node %d SwapCached: 0 kB" in sysfs when
> CONFIG_SWAP=n, which is probably wrong.  Shakeel, can you please have a
> think?

-- 
~Randy
You can't do anything without having to do something else first.
-- Belefant's Law