linux-kernel - Re: [PATCH v8 0/4] HID: i2c-hid: Reorganize to allow supporting goodix,gt7375p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=W3uzNPwAGPCUfjC-zoWEPyY4bF8TE4JgPP21s-3MAfpQ@mail.gmail.com>
Date:   Wed, 13 Jan 2021 07:58:56 -0800
From:   Doug Anderson <dianders@...omium.org>
To:     Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:     Jiri Kosina <jkosina@...e.cz>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Hans de Goede <hdegoede@...hat.com>,
        "open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Rob Herring <robh+dt@...nel.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Andrea Borgia <andrea@...gia.bo.it>,
        Anson Huang <Anson.Huang@....com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Daniel Playfair Cal <daniel.playfair.cal@...il.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Guido Günther <agx@...xcpu.org>,
        Jiri Kosina <jikos@...nel.org>, Li Yang <leoyang.li@....com>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Max Krummenacher <max.oss.09@...il.com>,
        Michael Walle <michael@...le.cc>,
        Pavel Balan <admin@...ma.net>, Shawn Guo <shawnguo@...nel.org>,
        Vinod Koul <vkoul@...nel.org>, Will Deacon <will@...nel.org>,
        Xiaofei Tan <tanxiaofei@...wei.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v8 0/4] HID: i2c-hid: Reorganize to allow supporting goodix,gt7375p

Hi,

On Wed, Jan 13, 2021 at 7:09 AM Benjamin Tissoires
<benjamin.tissoires@...hat.com> wrote:
>
> > I wanted to apply the series yesterday, but for these kinds of changes
> > I like giving it a spin on actual hardware. Turns out that my XPS-13
> > can not boot to v5.11-rc2, which makes testing the new branch slightly
> > more difficult.
> >
> > I'll give it a spin next week, but I think I should be able to land it for 5.12.
> >
> > Regarding the defconfig conflict, no worries, we can handle it with
> > Stephen and Linus.
> >
>
> After 2 full kernel bisects (I messed up the first because I am an
> idiot and inverted good and bad after the first reboot), I found my
> culprit, and I was able to test the series today.
>
> The series works fine regarding enumeration and removing of devices,
> but it prevents my system from being suspended. If I rmmod
> i2c-hid-acpi, suspend works fine, but if it is present, it immediately
> comes back, which makes me think that something must be wrong.
>
> I also just reverted the series and confirmed that suspend/resume now
> works, meaning that patch 1/4 needs to be checked.

Can you give me any hints about what type of failure you're seeing?
Any logs?  I don't have an ACPI system to test with...

Is there any chance that some type of userspace / udev rule is getting
tripped up by the driver being renamed?  We ran into something like
this recently on Chrome OS where we had a tool that was hardcoded to
look for "i2c-hid" and needed to be adapted to account for the new
driver name.  Often userspace tweaks with wakeup rules based on driver
name...

I'll go stare at the code now and see if anything jumps out.

-Doug