linux-kernel - Re: [PATCH v1 1/1] hsu_dma_pci: disable spurious interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210113163216.GW2771@vkoul-mobl>
Date:   Wed, 13 Jan 2021 22:02:16 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Ferry Toth <ftoth@...londelft.nl>,
        dmaengine <dmaengine@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v1 1/1] hsu_dma_pci: disable spurious interrupt

On 13-01-21, 15:05, Andy Shevchenko wrote:
> On Wed, Jan 13, 2021 at 5:23 AM Ferry Toth <ftoth@...londelft.nl> wrote:
> >
> > On Intel Tangier B0 and Anniedale the interrupt line, disregarding
> > to have different numbers, is shared between HSU DMA and UART IPs.
> > Thus on such SoCs we are expecting that IRQ handler is called in
> > UART driver only. hsu_pci_irq was handling the spurious interrupt
> 
> hsu_pci_irq()
> 
> > from HSU DMA by returning immediately. This wastes CPU time and
> > since HSU DMA and HSU UART interrupt occur simultaneously they race
> > to be handled causing delay to the HSU UART interrupt handling.
> > Fix this by disabling the interrupt entirely.
> 
> Title should be "dmaengine: hsu: ..."

Fixed that up while applying, so applied

-- 
~Vinod