linux-kernel - Re: [PATCH v2] usb: cdnsp: fixes undefined reference to cdns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13f338f1-9ba9-c848-0b75-10e73e8c6a7d@infradead.org>
Date:   Wed, 13 Jan 2021 09:52:30 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Pawel Laszczak <pawell@...ence.com>, peter.chen@....com
Cc:     a-govindraju@...com, gregkh@...uxfoundation.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        kurahul@...ence.com, geert@...ux-m68k.org
Subject: Re: [PATCH v2] usb: cdnsp: fixes undefined reference to cdns_remove

On 1/13/21 6:14 AM, Pawel Laszczak wrote:
> Patch fixes the following errors:
> ld: drivers/usb/cdns3/cdnsp-pci.o: in function `cdnsp_pci_remove':
> cdnsp-pci.c:(.text+0x80): undefined reference to `cdns_remove'
> ld: drivers/usb/cdns3/cdnsp-pci.o: in function `cdnsp_pci_probe':
> cdnsp-pci.c:(.text+0x34c): undefined reference to `cdns_init'
> 
> Issue occurs for USB/CDNS3/CDNSP kernel configuration:
> CONFIG_USB=m
> CONFIG_USB_CDNS_SUPPORT=y
> CONFIG_USB_CDNS3=m
> CONFIG_USB_CDNS3_PCI_WRAP=m
> CONFIG_USB_CDNSP_PCI=y
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Pawel Laszczak <pawell@...ence.com>

After removing the v1 patch and applying this one, my build errors are gone.
Thanks.

Acked-by: Randy Dunlap <rdunlap@...radead.org>

> ---
> changelog:
> v2
> - added missing condition
> 
>  drivers/usb/cdns3/Makefile | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/usb/cdns3/Makefile b/drivers/usb/cdns3/Makefile
> index 3f9b7fa8a594..61edb2f89276 100644
> --- a/drivers/usb/cdns3/Makefile
> +++ b/drivers/usb/cdns3/Makefile
> @@ -26,7 +26,15 @@ obj-$(CONFIG_USB_CDNS3_TI)			+= cdns3-ti.o
>  obj-$(CONFIG_USB_CDNS3_IMX)			+= cdns3-imx.o
>  
>  cdnsp-udc-pci-y					:= cdnsp-pci.o
> +
> +ifdef CONFIG_USB_CDNSP_PCI
> +ifeq ($(CONFIG_USB),m)
> +obj-m						+= cdnsp-udc-pci.o
> +else
>  obj-$(CONFIG_USB_CDNSP_PCI) 			+= cdnsp-udc-pci.o
> +endif
> +endif
> +
>  cdnsp-udc-pci-$(CONFIG_USB_CDNSP_GADGET)	+= cdnsp-ring.o cdnsp-gadget.o \
>  						   cdnsp-mem.o cdnsp-ep0.o
>  
> 


-- 
~Randy
You can't do anything without having to do something else first.
-- Belefant's Law