lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 12 Jan 2021 17:26:47 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Leo Li <sunpeng.li@....com>, LKML <linux-kernel@...r.kernel.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        David Airlie <airlied@...ux.ie>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>
Subject: Re: [PATCH 25/40] drm/amd/display/dc/dce120/dce120_timing_generator:
 Remove unused function 'dce120_timing_generator_get_position'

On Mon, Jan 11, 2021 at 2:20 PM Lee Jones <lee.jones@...aro.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_timing_generator.c:602:13: warning: ‘dce120_timing_generator_get_position’ defined but not used [-Wunused-function]
>
> Cc: Harry Wentland <harry.wentland@....com>
> Cc: Leo Li <sunpeng.li@....com>
> Cc: Alex Deucher <alexander.deucher@....com>
> Cc: "Christian König" <christian.koenig@....com>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: amd-gfx@...ts.freedesktop.org
> Cc: dri-devel@...ts.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Applied.  Thanks!

Alex

> ---
>  .../dc/dce120/dce120_timing_generator.c       | 43 -------------------
>  1 file changed, 43 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_timing_generator.c b/drivers/gpu/drm/amd/display/dc/dce120/dce120_timing_generator.c
> index d02ecb983c9cd..b57c466124e76 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_timing_generator.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_timing_generator.c
> @@ -589,49 +589,6 @@ static void dce120_timing_generator_set_drr(
>         }
>  }
>
> -/*
> - *****************************************************************************
> - *  Function: dce120_timing_generator_get_position
> - *
> - *  @brief
> - *     Returns CRTC vertical/horizontal counters
> - *
> - *  @param [out] position
> - *****************************************************************************
> - */
> -static void dce120_timing_generator_get_position(struct timing_generator *tg,
> -       struct crtc_position *position)
> -{
> -       uint32_t value;
> -       struct dce110_timing_generator *tg110 = DCE110TG_FROM_TG(tg);
> -
> -       value = dm_read_reg_soc15(
> -                       tg->ctx,
> -                       mmCRTC0_CRTC_STATUS_POSITION,
> -                       tg110->offsets.crtc);
> -
> -       position->horizontal_count = get_reg_field_value(
> -                       value,
> -                       CRTC0_CRTC_STATUS_POSITION,
> -                       CRTC_HORZ_COUNT);
> -
> -       position->vertical_count = get_reg_field_value(
> -                       value,
> -                       CRTC0_CRTC_STATUS_POSITION,
> -                       CRTC_VERT_COUNT);
> -
> -       value = dm_read_reg_soc15(
> -                       tg->ctx,
> -                       mmCRTC0_CRTC_NOM_VERT_POSITION,
> -                       tg110->offsets.crtc);
> -
> -       position->nominal_vcount = get_reg_field_value(
> -                       value,
> -                       CRTC0_CRTC_NOM_VERT_POSITION,
> -                       CRTC_VERT_COUNT_NOM);
> -}
> -
> -
>  static void dce120_timing_generator_get_crtc_scanoutpos(
>         struct timing_generator *tg,
>         uint32_t *v_blank_start,
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Powered by blists - more mailing lists