linux-kernel - Re: [PATCH v1] net/ipv4: add IPv4_is_multicast() check in ip_mc_leave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210112181744.028dc6bc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 12 Jan 2021 18:17:44 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     wangyingjie55@....com
Cc:     davem@...emloft.net, kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] net/ipv4: add IPv4_is_multicast() check in
 ip_mc_leave_group().

On Tue, 12 Jan 2021 00:47:09 -0800 wangyingjie55@....com wrote:
> From: Yingjie Wang <wangyingjie55@....com>
> 
> There is no IPv4_is_multicast() check added to ip_mc_leave_group()
> to determine whether imr->imr_multiaddr.s_addr is a multicast address.
> If not a multicast address, it may result in an error.
> In some cases, the callers of ip_mc_leave_group don't check
> whether it is multicast address or not such as do_ip_setsockopt().
> So I suggest added the ipv4_is_multicast() check to the
> ip_mc_leave_group function to prevent this from happening.
> 
> Fixes: d519aa299494 ("net/ipv4: add IPv4_is_multicast() check in ip_mc_leave_group().")
> Signed-off-by: Yingjie Wang <wangyingjie55@....com>

Same story with the fixes tag as on your other submission.

The fixes tag is supposed to refer to the commit which introduced 
the bug. It helps the backporters determine whether they need to
backport given fix to their trees. In case the commit which added 
the bug predates git history you can refer to the first commit in
the history.

HTH