linux-kernel - Re: [PATCH] X.509: Fix crash caused by NULL pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 13 Jan 2021 11:02:38 +0800
From:   Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
To:     David Howells <dhowells@...hat.com>
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Gilad Ben-Yossef <gilad@...yossef.com>,
        Tobias Markus <tobias@...kus-regensburg.de>,
        Tee Hao Wei <angelsl@...4.sg>, keyrings@...r.kernel.org,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH] X.509: Fix crash caused by NULL pointer



On 1/7/21 6:58 PM, David Howells wrote:
> Tianjia Zhang <tianjia.zhang@...ux.alibaba.com> wrote:
> 
>> On the following call path, `sig->pkey_algo` is not assigned
>> in asymmetric_key_verify_signature(), which causes runtime
>> crash in public_key_verify_signature().
>>
>>    keyctl_pkey_verify
>>      asymmetric_key_verify_signature
>>        verify_signature
>>          public_key_verify_signature
>>
>> This patch simply check this situation and fixes the crash
>> caused by NULL pointer.
>>
>> Fixes: 215525639631 ("X.509: support OSCCA SM2-with-SM3 certificate verification")
>> Cc: stable@...r.kernel.org # v5.10+
>> Reported-by: Tobias Markus <tobias@...kus-regensburg.de>
>> Signed-off-by: Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
> 
> Looks reasonable:
> 
> Acked-by: David Howells <dhowells@...hat.com>
> 
> I wonder, though, if cert_sig_digest_update() should be obtained by some sort
> of function pointer.  It doesn't really seem to belong in this file.  But this
> is a separate issue.
> 
> David
> 

Yes, this is indeed the logic of the SM2 module. I have tried to 
dynamically load and obtain the pointer of this function through 
`request_module` before, but this method still does not seem very 
suitable. Here are some unfinished codes I tried before:

https://github.com/uudiin/linux/commit/55bca48c6282415d94c53a7692622d544da99342

It would be great if you have some good experience to share with me, I 
will continue to try to optimize this code.

Best regards,
Tianjia