linux-kernel - Re: [PATCH 1/2] misc: eeprom_93xx46: Fix module alias to enable module autoprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 13 Jan 2021 10:45:54 +0530
From:   Aswath Govindraju <a-govindraju@...com>
To:     Vignesh Raghavendra <vigneshr@...com>
CC:     Sekhar Nori <nsekhar@...com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Pratyush Yadav <p.yadav@...com>, Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Vadym Kochan <vadym.kochan@...ision.eu>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Anatolij Gustschin <agust@...x.de>,
        Randy Dunlap <rdunlap@...radead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] misc: eeprom_93xx46: Fix module alias to enable
 module autoprobe

On 12/01/21 12:49 pm, Vignesh Raghavendra wrote:
> 
> 
> On 1/7/21 10:09 PM, Aswath Govindraju wrote:
>> Fix module autoprobe by correcting module alias to match the string from
>> /sys/class/.../spi1.0/modalias content.
>>
>> Fixes: 06b4501e88ad ("misc/eeprom: add driver for microwire 93xx46 EEPROMs")
>> Signed-off-by: Aswath Govindraju <a-govindraju@...com>
>> ---
>>  drivers/misc/eeprom/eeprom_93xx46.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/misc/eeprom/eeprom_93xx46.c b/drivers/misc/eeprom/eeprom_93xx46.c
>> index a18247696ce7..890624d97774 100644
>> --- a/drivers/misc/eeprom/eeprom_93xx46.c
>> +++ b/drivers/misc/eeprom/eeprom_93xx46.c
>> @@ -526,4 +526,4 @@ module_spi_driver(eeprom_93xx46_driver);
>>  MODULE_LICENSE("GPL");
>>  MODULE_DESCRIPTION("Driver for 93xx46 EEPROMs");
>>  MODULE_AUTHOR("Anatolij Gustschin <agust@...x.de>");
>> -MODULE_ALIAS("spi:93xx46");
> 
> This will break non DT users of this driver like
> drivers/misc/eeprom/digsy_mtc_eeprom.c
> 
>> +MODULE_ALIAS("spi:eeprom-93xx46");
>>
> 
> Can be a new entry.
> 

Thank you for the comments. Addressed this by sending a follow up patch,
https://lore.kernel.org/patchwork/patch/1364431/

Thanks,
Aswath