linux-kernel - Re: [PATCH 37/40] drm/amd/display/dc/dce60/dce60_resource: Make local functions static

Open Source and information security mailing list archives

Message-ID: <CADnq5_O=6HukSMAkHK5Cot5URYphtqwEa+t-pL38o=LYHBZRVw@mail.gmail.com>
Date:   Tue, 12 Jan 2021 17:39:36 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Leo Li <sunpeng.li@....com>, Mauro Rossi <issor.oruam@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        David Airlie <airlied@...ux.ie>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>
Subject: Re: [PATCH 37/40] drm/amd/display/dc/dce60/dce60_resource: Make local
 functions static

On Mon, Jan 11, 2021 at 2:20 PM Lee Jones <lee.jones@...aro.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:522:17: warning: no previous prototype for ‘dce60_aux_engine_create’ [-Wmissing-prototypes]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:560:20: warning: no previous prototype for ‘dce60_i2c_hw_create’ [-Wmissing-prototypes]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:576:20: warning: no previous prototype for ‘dce60_i2c_sw_create’ [-Wmissing-prototypes]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:710:22: warning: no previous prototype for ‘dce60_link_encoder_create’ [-Wmissing-prototypes]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:749:22: warning: no previous prototype for ‘dce60_clock_source_create’ [-Wmissing-prototypes]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:773:6: warning: no previous prototype for ‘dce60_clock_source_destroy’ [-Wmissing-prototypes]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:863:6: warning: no previous prototype for ‘dce60_validate_bandwidth’ [-Wmissing-prototypes]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce60/dce60_resource.c:908:16: warning: no previous prototype for ‘dce60_validate_global’ [-Wmissing-prototypes]
>
> Cc: Harry Wentland <harry.wentland@....com>
> Cc: Leo Li <sunpeng.li@....com>
> Cc: Alex Deucher <alexander.deucher@....com>
> Cc: "Christian König" <christian.koenig@....com>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: Mauro Rossi <issor.oruam@...il.com>
> Cc: amd-gfx@...ts.freedesktop.org
> Cc: dri-devel@...ts.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Applied.  Thanks!

Alex

> ---
>  .../drm/amd/display/dc/dce60/dce60_resource.c    | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> index e9dd78c484d6e..64f4a0da146bf 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> @@ -519,7 +519,7 @@ static struct output_pixel_processor *dce60_opp_create(
>         return &opp->base;
>  }
>
> -struct dce_aux *dce60_aux_engine_create(
> +static struct dce_aux *dce60_aux_engine_create(
>         struct dc_context *ctx,
>         uint32_t inst)
>  {
> @@ -557,7 +557,7 @@ static const struct dce_i2c_mask i2c_masks = {
>                 I2C_COMMON_MASK_SH_LIST_DCE_COMMON_BASE(_MASK)
>  };
>
> -struct dce_i2c_hw *dce60_i2c_hw_create(
> +static struct dce_i2c_hw *dce60_i2c_hw_create(
>         struct dc_context *ctx,
>         uint32_t inst)
>  {
> @@ -573,7 +573,7 @@ struct dce_i2c_hw *dce60_i2c_hw_create(
>         return dce_i2c_hw;
>  }
>
> -struct dce_i2c_sw *dce60_i2c_sw_create(
> +static struct dce_i2c_sw *dce60_i2c_sw_create(
>         struct dc_context *ctx)
>  {
>         struct dce_i2c_sw *dce_i2c_sw =
> @@ -707,7 +707,7 @@ static const struct encoder_feature_support link_enc_feature = {
>                 .flags.bits.IS_TPS3_CAPABLE = true
>  };
>
> -struct link_encoder *dce60_link_encoder_create(
> +static struct link_encoder *dce60_link_encoder_create(
>         const struct encoder_init_data *enc_init_data)
>  {
>         struct dce110_link_encoder *enc110 =
> @@ -746,7 +746,7 @@ static struct panel_cntl *dce60_panel_cntl_create(const struct panel_cntl_init_d
>         return &panel_cntl->base;
>  }
>
> -struct clock_source *dce60_clock_source_create(
> +static struct clock_source *dce60_clock_source_create(
>         struct dc_context *ctx,
>         struct dc_bios *bios,
>         enum clock_source_id id,
> @@ -770,7 +770,7 @@ struct clock_source *dce60_clock_source_create(
>         return NULL;
>  }
>
> -void dce60_clock_source_destroy(struct clock_source **clk_src)
> +static void dce60_clock_source_destroy(struct clock_source **clk_src)
>  {
>         kfree(TO_DCE110_CLK_SRC(*clk_src));
>         *clk_src = NULL;
> @@ -860,7 +860,7 @@ static void dce60_resource_destruct(struct dce110_resource_pool *pool)
>         }
>  }
>
> -bool dce60_validate_bandwidth(
> +static bool dce60_validate_bandwidth(
>         struct dc *dc,
>         struct dc_state *context,
>         bool fast_validate)
> @@ -905,7 +905,7 @@ static bool dce60_validate_surface_sets(
>         return true;
>  }
>
> -enum dc_status dce60_validate_global(
> +static enum dc_status dce60_validate_global(
>                 struct dc *dc,
>                 struct dc_state *context)
>  {
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives