linux-kernel - Re: [PATCH v4 1/2] dt-bindings: input: cros-ec-keyb: Add a new property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <161052072608.3661239.3835950564432313633@swboyd.mtv.corp.google.com>
Date:   Tue, 12 Jan 2021 22:52:06 -0800
From:   Stephen Boyd <swboyd@...omium.org>
To:     Philip Chen <philipchen@...omium.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Douglas Anderson <dianders@...omium.org>,
        Benson Leung <bleung@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>,
        Rob Herring <robh+dt@...nel.org>,
        Simon Glass <sjg@...omium.org>, devicetree@...r.kernel.org,
        linux-input@...r.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: input: cros-ec-keyb: Add a new property

Quoting Philip Chen (2021-01-12 15:29:11)
> On Mon, Jan 11, 2021 at 6:10 PM Stephen Boyd <swboyd@...omium.org> wrote:
> > Quoting Philip Chen (2021-01-07 15:42:08)
> > > ---
> > > diff --git a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> > > index 8e50c14a9d778..7acdb33781d30 100644
> > > --- a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> > > +++ b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> > > @@ -31,6 +31,16 @@ properties:
> > >        if the EC does not have its own logic or hardware for this.
> > >      type: boolean
> > >
> > > +  function-row-physmap:
> >
> > Is there any minimum/maximum number of elements possible?
> The maximum is 15.
> There is no definition for the minimum - we can probably say the minimum is 1.

Ok cool. Please add min/max of 1 to 15 to the binding.

> >
> > > +    $ref: '/schemas/types.yaml#/definitions/uint32-array'
> > > +    description: |
> > > +      An ordered u32 array describing the rows/columns (in the scan matrix)
> > > +      of top row keys from physical left (KEY_F1) to right. Each entry
> > > +      encodes the row/column as:
> > > +      (((row) & 0xFF) << 24) | (((column) & 0xFF) << 16)
> > > +      where the lower 16 bits are reserved. This property is specified only
> > > +      when the keyboard has a custom design for the top row keys.
> > > +