lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 12 Jan 2021 14:57:58 -0800 From: Nick Desaulniers <ndesaulniers@...gle.com> To: Will Deacon <will@...nel.org> Cc: Linux ARM <linux-arm-kernel@...ts.infradead.org>, kernel-team <kernel-team@...roid.com>, LKML <linux-kernel@...r.kernel.org>, "Theodore Ts'o" <tytso@....edu>, Catalin Marinas <catalin.marinas@....com>, Florian Weimer <fweimer@...hat.com>, Peter Zijlstra <peterz@...radead.org>, Linus Torvalds <torvalds@...ux-foundation.org>, Russell King <linux@...linux.org.uk>, Arnd Bergmann <arnd@...nel.org>, Jonathan Corbet <corbet@....net> Subject: Re: [PATCH] compiler.h: Raise minimum version of GCC to 5.1 for arm64 On Tue, Jan 12, 2021 at 2:48 PM Will Deacon <will@...nel.org> wrote: > > GCC versions >= 4.9 and < 5.1 have been shown to emit memory references > beyond the stack pointer, resulting in memory corruption if an interrupt > is taken after the stack pointer has been adjusted but before the > reference has been executed. This leads to subtle, infrequent data > corruption such as the EXT4 problems reported by Russell King at the > link below. > > Life is too short for buggy compilers, so raise the minimum GCC version > required by arm64 to 5.1. > > Cc: Theodore Ts'o <tytso@....edu> > Cc: Catalin Marinas <catalin.marinas@....com> > Cc: Florian Weimer <fweimer@...hat.com> > Cc: Peter Zijlstra <peterz@...radead.org> > Cc: Linus Torvalds <torvalds@...ux-foundation.org> > Cc: Nick Desaulniers <ndesaulniers@...gle.com> > Reported-by: Russell King <linux@...linux.org.uk> > Suggested-by: Arnd Bergmann <arnd@...nel.org> > Link: https://lore.kernel.org/r/20210105154726.GD1551@shell.armlinux.org.uk > Signed-off-by: Will Deacon <will@...nel.org> Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com> > --- > include/linux/compiler-gcc.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h > index 74c6c0486eed..555ab0fddbef 100644 > --- a/include/linux/compiler-gcc.h > +++ b/include/linux/compiler-gcc.h > @@ -13,6 +13,12 @@ > /* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 */ > #if GCC_VERSION < 40900 > # error Sorry, your version of GCC is too old - please use 4.9 or newer. > +#elif defined(CONFIG_ARM64) && GCC_VERSION < 50100 > +/* > + * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63293 > + * https://lore.kernel.org/r/20210107111841.GN1551@shell.armlinux.org.uk > + */ > +# error Sorry, your version of GCC is too old - please use 5.1 or newer. > #endif > > /* > -- > 2.30.0.284.gd98b1dd5eaa7-goog > -- Thanks, ~Nick Desaulniers
Powered by blists - more mailing lists