linux-kernel - Re: [PATCH] drivers: add new VID/PID for supporting Teraoka AD2000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <X/7G1LAzmTpfbPQF@hovoldconsulting.com>
Date:   Wed, 13 Jan 2021 11:09:24 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Jin ChenXin <bg4akv@...mail.com>
Cc:     Johan Hovold <johan@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: add new VID/PID for supporting Teraoka AD2000

On Wed, Jan 13, 2021 at 09:03:36AM +0000, Jin ChenXin wrote:

Thanks for the patch. I've applied it now after fixing up some minor
nits (so you don't need to resend), but for next time please consider
the following comments.

> From 905036e81e0d32705379c40acddb634428aff0a6 Mon Sep 17 00:00:00 2001

Don't include this line since it prevents git-am from considering the
following lines.

It also seems hotmail base64-encoded your message, which you should try
to avoid (see Documentation/process/email-clients.rst).

> From: Chenxin Jin <bg4akv@...mail.com>
> Date: Wed, 13 Jan 2021 16:59:05 +0800
> Subject: [PATCH] drivers: add new VID/PID for supporting Teraoka AD2000

Please use the same commit-summary prefix as other commits for the
subsystem and driver you're patching (e.g. "USB: serial: cp210x: ")

> Teraoka AD2000 uses the CP210x driver, but the chip VID/PID is
> customized with 0988/0578. We need the driver to support the new VID/PID.
> 
> Signed-off-by: Chenxin Jin <bg4akv@...mail.com>
> ---
>  drivers/usb/serial/cp210x.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index fbb10df..c274cc3 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
> @@ -234,6 +234,7 @@ static int cp210x_tiocmset_port(struct usb_serial_port *port,
>  	{ USB_DEVICE(0x3195, 0xF281) }, /* Link Instruments MSO-28 */
>  	{ USB_DEVICE(0x3923, 0x7A0B) }, /* National Instruments USB Serial Console */
>  	{ USB_DEVICE(0x413C, 0x9500) }, /* DW700 GPS USB interface */
> +	{ USB_DEVICE(0x0988, 0x0578) }, /* Teraoka AD2000 */

When possible, try to keep the entries ordered by VID and PID.

>  	{ } /* Terminating Entry */
>  };

The end-result is here:

	https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-linus&id=43377df70480f82919032eb09832e9646a8a5efb

Johan