linux-kernel - Re: [PATCH RESEND] random: fix the RNDRESEEDCRNG ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXGC+TXPCPhVj6KisCPfCZHfRFF45zBiU1KjaBXOsL0xkg@mail.gmail.com>
Date:   Wed, 13 Jan 2021 12:51:55 +0100
From:   Ard Biesheuvel <ardb@...nel.org>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "# 3.4.x" <stable@...r.kernel.org>,
        Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
        Andy Lutomirski <luto@...nel.org>,
        Jann Horn <jannh@...gle.com>, "Theodore Ts'o" <tytso@....edu>
Subject: Re: [PATCH RESEND] random: fix the RNDRESEEDCRNG ioctl

On Tue, 12 Jan 2021 at 20:30, Eric Biggers <ebiggers@...nel.org> wrote:
>
> From: Eric Biggers <ebiggers@...gle.com>
>
> The RNDRESEEDCRNG ioctl reseeds the primary_crng from itself, which
> doesn't make sense.  Reseed it from the input_pool instead.
>
> Fixes: d848e5f8e1eb ("random: add new ioctl RNDRESEEDCRNG")
> Cc: stable@...r.kernel.org
> Cc: linux-crypto@...r.kernel.org
> Cc: Andy Lutomirski <luto@...nel.org>
> Cc: Jann Horn <jannh@...gle.com>
> Cc: Theodore Ts'o <tytso@....edu>
> Reviewed-by: Jann Horn <jannh@...gle.com>
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Acked-by: Ard Biesheuvel <ardb@...nel.org>

> ---
>
> Andrew, please consider taking this patch since the maintainer has been
> ignoring it for 4 months
> (https://lkml.kernel.org/lkml/20200916041908.66649-1-ebiggers@kernel.org/T/#u).
>
>
>  drivers/char/random.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/random.c b/drivers/char/random.c
> index 5f3b8ac9d97b0..a894c0559a8cf 100644
> --- a/drivers/char/random.c
> +++ b/drivers/char/random.c
> @@ -1972,7 +1972,7 @@ static long random_ioctl(struct file *f, unsigned int cmd, unsigned long arg)
>                         return -EPERM;
>                 if (crng_init < 2)
>                         return -ENODATA;
> -               crng_reseed(&primary_crng, NULL);
> +               crng_reseed(&primary_crng, &input_pool);
>                 crng_global_init_time = jiffies - 1;
>                 return 0;
>         default:
> --
> 2.30.0
>