linux-kernel - Re: [PATCH 1/2] mmc: rtsx: add delay before power on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 13 Jan 2021 14:07:30 +0100
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     吳昊澄 Ricky <ricky_wu@...ltek.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        feng@...lsil.com.cn, Doug Anderson <dianders@...omium.org>,
        Lee Jones <lee.jones@...aro.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] mmc: rtsx: add delay before power on

On Wed, 13 Jan 2021 at 11:57, <ricky_wu@...ltek.com> wrote:
>
> From: Ricky Wu <ricky_wu@...ltek.com>
>
> Make sure voltage below 0.5V before power on
> when do power cycle
> At mmc-core recognition card phase will do
> power cycle quickly so our device need at least 100ms
> to make voltage down to below 0.5V
>
> Signed-off-by: Ricky Wu <ricky_wu@...ltek.com>

Applied for next, by amending the changelog a bit, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/rtsx_pci_sdmmc.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c b/drivers/mmc/host/rtsx_pci_sdmmc.c
> index e6f5bbce5685..0e5043a03965 100644
> --- a/drivers/mmc/host/rtsx_pci_sdmmc.c
> +++ b/drivers/mmc/host/rtsx_pci_sdmmc.c
> @@ -906,6 +906,8 @@ static int sd_power_on(struct realtek_pci_sdmmc *host)
>         if (host->power_state == SDMMC_POWER_ON)
>                 return 0;
>
> +       msleep(100);
> +
>         rtsx_pci_init_cmd(pcr);
>         rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, CARD_SELECT, 0x07, SD_MOD_SEL);
>         rtsx_pci_add_cmd(pcr, WRITE_REG_CMD, CARD_SHARE_MODE,
> --
> 2.17.1
>