linux-kernel - Re: [PATCH] scripts: kconfig: fix HOSTCC call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 15 Jan 2021 04:00:13 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     "Enrico Weigelt, metux IT consult" <info@...ux.net>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>
Subject: Re: [PATCH] scripts: kconfig: fix HOSTCC call

On Thu, Jan 14, 2021 at 7:05 PM Enrico Weigelt, metux IT consult
<info@...ux.net> wrote:
>

Thanks for catching this.


> The change c0f975af1745391749e4306aa8081b9a4d2cced8 introduces a bug when

Please use 12-digit hash ("subject") style.


Commit c0f975af1745 ("kconfig: Support building mconf with vendor
sysroot ncurses")



> HOSTCC contains parameters: the whole command line is treated as the program
> name (with spaces in it). Therefore, we have to remove the quotes.
>
> Fixes: c0f975af1745391749e4306aa8081b9a4d2cced8

Ditto.

Fixes: c0f975af1745 ("kconfig: Support building mconf with vendor
sysroot ncurses")



> Signed-off-by: Enrico Weigelt, metux IT consult <info@...ux.net>
> ---
>  scripts/kconfig/mconf-cfg.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/mconf-cfg.sh b/scripts/kconfig/mconf-cfg.sh
> index fcd4acd4e9cb..40fa449ed049 100755
> --- a/scripts/kconfig/mconf-cfg.sh
> +++ b/scripts/kconfig/mconf-cfg.sh
> @@ -35,7 +35,7 @@ fi
>
>  # As a final fallback before giving up, check if $HOSTCC knows of a default
>  # ncurses installation (e.g. from a vendor-specific sysroot).
> -if echo '#include <ncurses.h>' | "${HOSTCC}" -E - >/dev/null 2>&1; then
> +if echo '#include <ncurses.h>' | ${HOSTCC} -E - >/dev/null ; then


Please keep 2>&1.

This script will display the enough error message at the end.



>         echo cflags=\"-D_GNU_SOURCE\"
>         echo libs=\"-lncurses\"
>         exit 0
> --
> 2.11.0
>


-- 
Best Regards
Masahiro Yamada