linux-kernel - Re: [PATCH v2] perf test: Fix shadow stat test for non-bash shells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210114190302.GE1416940@krava>
Date:   Thu, 14 Jan 2021 20:03:02 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Namhyung Kim <namhyung@...nel.org>, Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Stephane Eranian <eranian@...gle.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Ian Rogers <irogers@...gle.com>,
        David Laight <David.Laight@...lab.com>,
        Jin Yao <yao.jin@...ux.intel.com>
Subject: Re: [PATCH v2] perf test: Fix shadow stat test for non-bash shells

On Thu, Jan 14, 2021 at 03:20:22PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Jan 14, 2021 at 02:06:09PM +0900, Namhyung Kim escreveu:
> > It was using some bash-specific features and failed to parse when
> > running with a different shell like below:
> > 
> >   root@...-ppc:~/kbl-ws/perf-dev/lck-9077/acme.tmp/tools/perf# ./perf test 83 -vv
> >   83: perf stat metrics (shadow stat) test                            :
> >   --- start ---
> >   test child forked, pid 3922
> >   ./tests/shell/stat+shadow_stat.sh: 19: ./tests/shell/stat+shadow_stat.sh: [[: not found
> >   ./tests/shell/stat+shadow_stat.sh: 24: ./tests/shell/stat+shadow_stat.sh: [[: not found
> >   ./tests/shell/stat+shadow_stat.sh: 30: ./tests/shell/stat+shadow_stat.sh: [[: not found
> >   (standard_in) 2: syntax error
> >   ./tests/shell/stat+shadow_stat.sh: 36: ./tests/shell/stat+shadow_stat.sh: [[: not found
> >   ./tests/shell/stat+shadow_stat.sh: 19: ./tests/shell/stat+shadow_stat.sh: [[: not found
> >   ./tests/shell/stat+shadow_stat.sh: 24: ./tests/shell/stat+shadow_stat.sh: [[: not found
> >   ./tests/shell/stat+shadow_stat.sh: 30: ./tests/shell/stat+shadow_stat.sh: [[: not found
> >   (standard_in) 2: syntax error
> >   ./tests/shell/stat+shadow_stat.sh: 36: ./tests/shell/stat+shadow_stat.sh: [[: not found
> >   ./tests/shell/stat+shadow_stat.sh: 45: ./tests/shell/stat+shadow_stat.sh: declare: not found
> >   test child finished with -1
> >   ---- end ----
> >   perf stat metrics (shadow stat) test: FAILED!
> 
> Jiri provided an Acked-by for v1, Jiri, can I keep it for this v2?

yep, v2 works for me

Acked-by: Jiri Olsa <jolsa@...hat.com>

jitka