linux-kernel - Re: [PATCH] x86/mm/mtrr: remove definition of DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <24593769-e2fe-7fd4-d212-0e6da58764cd@redhat.com>
Date:   Thu, 14 Jan 2021 11:25:16 -0800
From:   Tom Rix <trix@...hat.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        ying-tsun.huang@....com, peterz@...radead.org, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/mm/mtrr: remove definition of DEBUG


On 1/14/21 10:46 AM, Borislav Petkov wrote:
> On Thu, Jan 14, 2021 at 08:27:43AM -0800, trix@...hat.com wrote:
>> From: Tom Rix <trix@...hat.com>
>>
>> Defining DEBUG should only be done in development.
>> So remove DEBUG.
>>
>> Signed-off-by: Tom Rix <trix@...hat.com>
>> ---
>>  arch/x86/kernel/cpu/mtrr/generic.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c
>> index a29997e6cf9e..b90f3f437765 100644
>> --- a/arch/x86/kernel/cpu/mtrr/generic.c
>> +++ b/arch/x86/kernel/cpu/mtrr/generic.c
>> @@ -3,7 +3,6 @@
>>   * This only handles 32bit MTRR on 32bit hosts. This is strictly wrong
>>   * because MTRRs can span up to 40 bits (36bits on most modern x86)
>>   */
>> -#define DEBUG
>>  
>>  #include <linux/export.h>
>>  #include <linux/init.h>
> Wanna merge all 4 in arch/x86/
>
> arch/x86/kernel/cpu/mtrr/generic.c:6:#define DEBUG
> arch/x86/kernel/cpu/mtrr/mtrr.c:34:#define DEBUG
> arch/x86/kernel/pci-iommu_table.c:8:#define DEBUG 1
> arch/x86/mm/mmio-mod.c:13:#define DEBUG 1
>
> into a single patch?

Yes, i'll take care of that.

Tom

> Thx.
>