linux-kernel - Re: [RESEND PATCH v10 1/2] dt-bindings: dma: Add bindings for Intel LGM SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqJE59nA_Bvt1rL95WfeXjQkOSPiTZk8zAbdHSkujmS3gQ@mail.gmail.com>
Date:   Thu, 14 Jan 2021 14:25:48 -0600
From:   Rob Herring <robh+dt@...nel.org>
To:     Amireddy Mallikarjuna reddy <mallikarjunax.reddy@...ux.intel.com>
Cc:     "open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM" 
        <dmaengine@...r.kernel.org>, Vinod <vkoul@...nel.org>,
        devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andy Shevchenko <andriy.shevchenko@...el.com>,
        chuanhua.lei@...ux.intel.com,
        "Kim, Cheol Yong" <cheol.yong.kim@...el.com>,
        "Wu, Qiming" <qi-ming.wu@...el.com>, malliamireddy009@...il.com,
        Peter Ujfalusi <peter.ujfalusi@...com>
Subject: Re: [RESEND PATCH v10 1/2] dt-bindings: dma: Add bindings for Intel
 LGM SoC

On Tue, Dec 15, 2020 at 10:08 PM Amireddy Mallikarjuna reddy
<mallikarjunax.reddy@...ux.intel.com> wrote:
>
> Add DT bindings YAML schema for DMA controller driver
> of Lightning Mountain (LGM) SoC.
>
> Signed-off-by: Amireddy Mallikarjuna reddy <mallikarjunax.reddy@...ux.intel.com>
> Reviewed-by: Rob Herring <robh@...nel.org>
> ---
> v1:
> - Initial version.
>
> v2:
> - Fix bot errors.
>
> v3:
> - No change.
>
> v4:
> - Address Thomas langer comments
>   - use node name pattern as dma-controller as in common binding.
>   - Remove "_" (underscore) in instance name.
>   - Remove "port-" and "chan-" in attribute name for both 'dma-ports' & 'dma-channels' child nodes.
>
> v5:
> - Moved some of the attributes in 'dma-ports' & 'dma-channels' child nodes to dma client/consumer side as cells in 'dmas' properties.
>
> v6:
> - Add additionalProperties: false
> - completely removed 'dma-ports' and 'dma-channels' child nodes.
> - Moved channel dt properties to client side dmas.
> - Use standard dma-channels and dma-channel-mask properties.
> - Documented reset-names
> - Add description for dma-cells
>
> v7:
> - modified compatible to oneof
> - Reduced number of dma-cells to 3
> - Fine tune the description of some properties.
>
> v7-resend:
> - rebase to 5.10-rc1
> - No change.
>
> v8:
> - rebased to 5.10-rc3
> - Fixing the bot issues (wrong indentation)
>
> v9:
> - Use 'enum' instead of oneOf+const
> - Drop '#dma-cells' in required:, already covered in dma-common.yaml
> - Drop nodename Already covered by dma-controller.yaml
>
> v10:
> - rebased to 5.10-rc6
> - Add Reviewed-by: Rob Herring <robh@...nel.org>
> - Fixed typo.
> - moved property dma-desc-in-sram to driver side.
> - Moved property dma-orrc to driver side.
>
> v10-resend:
> - rebased to 5.10
> - No change
> ---
>  .../devicetree/bindings/dma/intel,ldma.yaml   | 116 ++++++++++++++++++
>  1 file changed, 116 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/dma/intel,ldma.yaml
>
> diff --git a/Documentation/devicetree/bindings/dma/intel,ldma.yaml b/Documentation/devicetree/bindings/dma/intel,ldma.yaml
> new file mode 100644
> index 000000000000..866d4c758a7a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/intel,ldma.yaml
> @@ -0,0 +1,116 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/dma/intel,ldma.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Lightning Mountain centralized DMA controllers.
> +
> +maintainers:
> +  - chuanhua.lei@...el.com
> +  - mallikarjunax.reddy@...el.com
> +
> +allOf:
> +  - $ref: "dma-controller.yaml#"
> +
> +properties:
> +  compatible:
> +    enum:
> +      - intel,lgm-cdma
> +      - intel,lgm-dma2tx
> +      - intel,lgm-dma1rx
> +      - intel,lgm-dma1tx
> +      - intel,lgm-dma0tx
> +      - intel,lgm-dma3
> +      - intel,lgm-toe-dma30
> +      - intel,lgm-toe-dma31
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#dma-cells":
> +    const: 3
> +    description:
> +      The first cell is the peripheral's DMA request line.
> +      The second cell is the peripheral's (port) number corresponding to the channel.
> +      The third cell is the burst length of the channel.
> +
> +  dma-channels:
> +    minimum: 1
> +    maximum: 16
> +
> +  dma-channel-mask:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  resets:
> +    maxItems: 1
> +
> +  reset-names:
> +    items:
> +      - const: ctrl
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  intel,dma-poll-cnt:
> +    $ref: /schemas/types.yaml#definitions/uint32

Since this was sent, there have been some fixes for JSON pointers and
this is missing a '/'. The tools now check:

/builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/dma/intel,ldma.yaml:
properties:intel,dma-poll-cnt: 'oneOf' conditional failed, one must be
fixed:
 'enum' is a required property
 'const' is a required property
 '/schemas/types.yaml#definitions/uint32' does not match
'types.yaml#/definitions/'

Please send a fix for this.

Thanks,
Rob